Closed
Bug 424841
Opened 16 years ago
Closed 16 years ago
Add license text for jemalloc to about:license
Categories
(Firefox :: General, defect, P2)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 3
People
(Reporter: gerv, Assigned: gerv)
Details
Attachments
(1 file)
14.74 KB,
patch
|
mconnor
:
review+
mconnor
:
superreview+
|
Details | Diff | Splinter Review |
Someone commented, upon the publication of the draft licence policy, that jemalloc and cairo were not listed. They are not; and neither is their relevant licence text included in about:licence. jemalloc: http://mxr.mozilla.org/mozilla/source/memory/jemalloc/jemalloc.c glitz: http://mxr.mozilla.org/mozilla/source/gfx/cairo/glitz/COPYING libpixman: http://mxr.mozilla.org/mozilla/source/gfx/cairo/libpixman/src/pixman-compose.c We should fix this. Gerv
Assignee | ||
Comment 1•16 years ago
|
||
Nominating as a blocker for final. We don't need this for beta. I'll get to a patch in the next couple of days. Gerv
Flags: blocking-firefox3?
Updated•16 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Assignee | ||
Comment 2•16 years ago
|
||
It turns out that libpixman and glitz are included in the general Cairo section. This patch does jemalloc, cleans up a few things, and adds a non-compulsory credit for sqlite. Gerv
Attachment #313066 -
Flags: review?(reed)
Comment 3•16 years ago
|
||
Stumbling on this bug I remembered that we put the OS/2 cairo code under copyright of netlabs.org. I guess that should be added to the Mozilla license text, too? See <http://mxr.mozilla.org/seamonkey/source/gfx/cairo/cairo/src/cairo-os2-surface.c#4> (it should really be 2005-2008 because we changed some stuff this year, I will fix that upstream in the cairo source).
Comment 4•16 years ago
|
||
Comment on attachment 313066 [details] [diff] [review] Patch v.1 We can probably remove the about:license bits from the toolkit version as well, but not now. Please land this ASAP, thanks!
Attachment #313066 -
Flags: superreview+
Attachment #313066 -
Flags: review?(reed)
Attachment #313066 -
Flags: review+
Updated•16 years ago
|
Whiteboard: [has patch][has reviews]
Assignee | ||
Comment 5•16 years ago
|
||
Checking in mail/license.html; /cvsroot/mozilla/mail/license.html,v <-- license.html new revision: 1.10; previous revision: 1.9 done Checking in toolkit/content/license.html; /cvsroot/mozilla/toolkit/content/license.html,v <-- license.html new revision: 1.19; previous revision: 1.18 done Checking in xpfe/global/resources/content/license.html; /cvsroot/mozilla/xpfe/global/resources/content/license.html,v <-- license.html new revision: 1.17; previous revision: 1.16 done Gerv
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Add licence text for jemalloc and bits of cairo to about:licence → Add licence text for jemalloc to about:licence
Updated•16 years ago
|
Summary: Add licence text for jemalloc to about:licence → Add license text for jemalloc to about:license
Whiteboard: [has patch][has reviews]
Comment 6•16 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050718 Minefield/3.0pre Verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•