Closed
Bug 424922
Opened 18 years ago
Closed 18 years ago
Radios and checkbuttons too close to their labels
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3 beta5
People
(Reporter: ventnor.bugzilla, Assigned: ventnor.bugzilla)
Details
(Keywords: regression)
Attachments
(1 file)
|
2.17 KB,
patch
|
rflint
:
review+
beltzner
:
approval1.9b5+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
The padding of these widgets were removed from the size calculation of the actual widgets and are now counted as padding. This is good for HTML, problem is in XUL this puts them too close to their labels. The fix is to add a CSS rule.
This regressed with dbaron's patch for radio and checkbox overflow, forgot the bug number and too lazy to look it up.
Attachment #311513 -
Flags: review?(rflint)
|
||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Component: Widget: Gtk → Theme
Product: Core → Firefox
QA Contact: gtk → theme
|
||
Updated•18 years ago
|
Attachment #311513 -
Flags: review?(rflint) → review+
|
Assignee | |
Comment 1•18 years ago
|
||
Comment on attachment 311513 [details] [diff] [review]
Patch
This will be a noticeable regression if left for B5 so we should fix it there if only to save the many future bug reports this will entail :P
Attachment #311513 -
Flags: approval1.9b5?
Attachment #311513 -
Flags: approval1.9?
|
||
Comment 2•18 years ago
|
||
Comment on attachment 311513 [details] [diff] [review]
Patch
a1.9b5=beltzner, now also accepting litmus testcases with screencaps showing what the correct spacing is so that we can be sure to test for it
Attachment #311513 -
Flags: approval1.9b5?
Attachment #311513 -
Flags: approval1.9b5+
Attachment #311513 -
Flags: approval1.9?
Attachment #311513 -
Flags: approval1.9+
|
|
Assignee | |
Updated•18 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•18 years ago
|
||
Checking in toolkit/themes/gnomestripe/global/checkbox.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/checkbox.css,v <-- checkbox.css
new revision: 1.7; previous revision: 1.6
done
Checking in toolkit/themes/gnomestripe/global/radio.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/radio.css,v <-- radio.css
new revision: 1.7; previous revision: 1.6
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
You need to log in
before you can comment on or make changes to this bug.
Description
•