Closed
Bug 424996
Opened 16 years ago
Closed 16 years ago
close.png should use close box with red background for active state
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 3 beta5
People
(Reporter: beltzner, Assigned: faaborg)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.86 KB,
image/png
|
beltzner
:
approval1.9b5+
beltzner
:
approval1.9+
|
Details |
See attachment 310986 [details] close.png - the first state is wrong, I think I believe that the states should be: active | hovered | pressed | inactive the newly checked in close.png has a grey background in the "normal" state, which makes it look inactive on luna (see http://img521.imageshack.us/my.php?image=zzvx8.jpg). Alex: can you update close.png and re-attach? It would be great if we could get this fixed for beta, as I've seen a bunch of people asking about it.
Flags: blocking-firefox3+
Assignee | ||
Comment 2•16 years ago
|
||
We will be revising the hover state later, but in the meantime please land this one.
Attachment #311654 -
Attachment is obsolete: true
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 3•16 years ago
|
||
Comment on attachment 311713 [details]
New close.png
A=Beltzner
Attachment #311713 -
Flags: approval1.9+
Updated•16 years ago
|
Attachment #311713 -
Flags: approval1.9b5?
Reporter | ||
Updated•16 years ago
|
Attachment #311713 -
Flags: approval1.9b5? → approval1.9b5+
Comment 4•16 years ago
|
||
Checking in toolkit/themes/winstripe/global/icons/close.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/close.png,v <-- close.png new revision: 1.6; previous revision: 1.5 done
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
Comment 5•16 years ago
|
||
(In reply to comment #2) > Created an attachment (id=311713) [details] > New close.png > > We will be revising the hover state later, but in the meantime please land this > one. Alex, have you already filed a new follow-up bug for the remaining issue? Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032605 Minefield/3.0b5pre ID:2008032605
Status: RESOLVED → VERIFIED
Keywords: regression
i corrected this already with my attachment. please see the original corrected close.png
Comment 7•16 years ago
|
||
But that one wasn't checked-in. Currently we don't have a hover effect.
Assignee | ||
Comment 8•16 years ago
|
||
>i corrected this already with my attachment
Due to issues regarding color profiles and additional levels of lossless compression (with optipng, pnggauntlet, etc), we are trying to limit the extent to which people modify and then check in images.
Comment 9•16 years ago
|
||
Does a bug has been filed for the missing hover state ?
Comment 10•16 years ago
|
||
i just did. Bug 426173 – Close.png needs hover state
You need to log in
before you can comment on or make changes to this bug.
Description
•