424996 - close.png should use close box with red background for active state

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

See attachment 310986 [details]
close.png - the first state is wrong, I think

I believe that the states should be:

active | hovered | pressed | inactive

the newly checked in close.png has a grey background in the "normal" state,
which makes it look inactive on luna (see
http://img521.imageshack.us/my.php?image=zzvx8.jpg).

Alex: can you update close.png and re-attach? It would be great if we could get this fixed for beta, as I've seen a bunch of people asking about it.

Comment 1

[Pat]

Attachment: Corrected close.png

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: New close.png

We will be revising the hover state later, but in the meantime please land this one.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 311713 [details]
New close.png

A=Beltzner

Comment 4

[Reed Loden [:reed]]

Checking in toolkit/themes/winstripe/global/icons/close.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/icons/close.png,v  <--  close.png
new revision: 1.6; previous revision: 1.5
done

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #2)
> Created an attachment (id=311713) [details]
> New close.png
> 
> We will be revising the hover state later, but in the meantime please land this
> one.

Alex, have you already filed a new follow-up bug for the remaining issue?

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032605 Minefield/3.0b5pre ID:2008032605

Comment 6

[Pat]

i corrected this already with my attachment. please see the original corrected close.png

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

But that one wasn't checked-in. Currently we don't have a hover effect.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

>i corrected this already with my attachment

Due to issues regarding color profiles and additional levels of lossless compression (with optipng, pnggauntlet, etc), we are trying to limit the extent to which people modify and then check in images.

Comment 9

[Darren Kalck [:D-Kalck]]

Does a bug has been filed for the missing hover state ?

Comment 10

[Pat]

i just did. Bug 426173 – Close.png needs hover state