425062 - FUEL: Error: Application is not defined

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Simon Bünzli]

Regression from bug 407963 in today's nightly (last known good: 2008032405). On the first start on a new profile I get...

Error: i is undefined
Source File: file:///C:/Programme/Mozilla%20Firefox/modules/XPCOMUtils.jsm
Line: 115
 ----------
Failed to load XPCOM component: C:\Programme\Mozilla Firefox\components\fuelApplication.js

... and trying to use FUEL results in...

Error: Application is not defined

Could this be a packing issue (as e.g. the new xpts missing)?

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> Could this be a packing issue (as e.g. the new xpts missing)?

Eek, probably.

Comment 2

[Simon Bünzli]

(In reply to comment #1)
> Eek, probably.

Don't we have any test machine which installs builds instead of compiling them? This wouldn't be the first time new components aren't properly packed even though all tests are passing...

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: package extApplication.js and exthelper.xpt

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 311651 [details] [diff] [review]
package extApplication.js and exthelper.xpt

a1.9b5=beltzner

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> (In reply to comment #1)
> > Eek, probably.
> 
> Don't we have any test machine which installs builds instead of compiling them?

Not yet, see bug 383136.

Comment 6

[Joey Minta]

Comment on attachment 311651 [details] [diff] [review]
package extApplication.js and exthelper.xpt

 ; JavaScript components
 bin/components/FeedProcessor.js
 bin/components/FeedConverter.js
 bin/components/FeedWriter.js
+bin/components/extApplication.js

We preprocess #include extApplication.js into fuelApplication.js, so I don't think it needs to be packaged.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/installer/unix/packages-static 	1.159
mozilla/browser/installer/windows/packages-static 	1.161 

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> We preprocess #include extApplication.js into fuelApplication.js, so I don't
> think it needs to be packaged.

Oops, you're right. I undid that change.