425076 - Review submission is sometimes broken:

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

Seems to only happen on this one add-on for me so far.  To reproduce:

1) Login (and hope you stay that way)
2) Load https://preview.addons.mozilla.org/en-US/firefox/addon/2731
3) Fill in a review and a rating
4) Click submit, see "There are errors in this form. Please correct them and resubmit."

If I do the same thing on my dev copy, I see at the top:

Query: INSERT INTO `reviews` (`id`,`title`,`rating`,`body`,`version_id`,`user_id`,`editorreview`,`created`,`modified`) VALUES ('',107968,3,107969,0,10482,1,'2008-03-25 14:32:56','2008-03-25 14:32:56')
Warning: SQL Error: 1452: Cannot add or update a child row: a foreign key constraint fails (`c_remora/reviews`, CONSTRAINT `reviews_ibfk_1` FOREIGN KEY (`version_id`) REFERENCES `versions` (`id`)) in /home/clouserw/public_html/remora/site/cake/libs/model/datasources/dbo_source.php on line 440

Comment 1

[Fred Wenzel [:wenzel]]

Looks like the new review box does not honor if somebody has already written a review before.

Comment 2

[Fred Wenzel [:wenzel]]

Actually, I was wrong, it doesn't have anything to do with an existing review. It wasn't possible to submit reviews for sandboxed add-ons unless you had "show experimental" activated, but we removed this restriction, so I nuked it in the reviews controller too now.

Fixed in r11601.