Migrate mail/components to frozen linkage for non-static linux builds

RESOLVED FIXED

Status

defect
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch The fixSplinter Review
As part of the ongoing effort to move Thunderbird onto libxul, I've migrated mail/components to frozen linkage.

This patch will only migrate non-static builds (i.e. developer builds), static builds will remain unaffected. If we were to affect static builds, then we'd be forced to move the mail/components items into a separate shared library, hence potentially affecting performance.

As we don't have any performance testing at the moment, but would like to preserve the code so that it does still work with frozen linkage, this is the best compromise that Dan and I came up with.

I've only done Linux as that's all I've got at the moment.
Attachment #311659 - Flags: superreview?(bienvenu)
Attachment #311659 - Flags: review?(bienvenu)
Comment on attachment 311659 [details] [diff] [review]
The fix

looks like a tab here:

-	}
+	if (!starting || name.IsEmpty())
+    return PR_FALSE;
+
Attachment #311659 - Flags: superreview?(bienvenu)
Attachment #311659 - Flags: superreview+
Attachment #311659 - Flags: review?(bienvenu)
Attachment #311659 - Flags: review+
Patch checked in with tab -> space. Fixed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.