Change duplicated accesskeys in Disk Space panels

VERIFIED FIXED

Status

SeaMonkey
MailNews: Account Configuration
--
trivial
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Giacomo Magnini, Assigned: Giacomo Magnini)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.73 KB, patch
Giacomo Magnini
: review+
philor
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9b5pre) Gecko/2008032504 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9b5pre) Gecko/2008032504 Minefield/3.0b5pre

The (Offline &) Disk Space panels in the account manager have many duplicated accesskeys. We should change some to solve the issue.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Assignee)

Comment 1

10 years ago
Created attachment 311772 [details] [diff] [review]
This should be it.

Tested with POP, IMAP, News, Movemail and Local Folders accounts.
(Assignee)

Updated

10 years ago
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk

Updated

10 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

10 years ago
Comment on attachment 311772 [details] [diff] [review]
This should be it.

>Index: suite/locales/en-US/chrome/mailnews/pref/am-offline.dtd
>===================================================================
> <!ENTITY nntpNotDownloadRead.label "Read messages">
>-<!ENTITY nntpNotDownloadRead.accesskey "R">
>+<!ENTITY nntpNotDownloadRead.accesskey "d">
> <!ENTITY nntpDownloadMsg.label "Messages more than">
> <!ENTITY nntpDownloadMsg.accesskey "e">
> <!ENTITY retentionCleanup.label "To recover disk space, old messages can be permanently deleted">
> <!ENTITY retentionKeepMsg.label "Delete messages more than">
>-<!ENTITY retentionKeepMsg.accesskey "m">
>+<!ENTITY retentionKeepMsg.accesskey "t">

Is there some possibility to change it to use "D" here? First-letter matches are preferred if possible, and "t" is suboptimal for being a bit narrow ("t" and "f" are still better than "l", "I" or "j" though).

Please also look if the matching Thunderbird file has the same problems.
(Assignee)

Comment 3

10 years ago
Can't use D, as I need it for "Read messages" in the same panel for Offline/Local Folders: otherwise I was left with no free accesskey for such a string.

Comment 4

10 years ago
Comment on attachment 311772 [details] [diff] [review]
This should be it.

bummer. OK, I don't really like it but see no better solution. r= me.
Attachment #311772 - Flags: review+
(Assignee)

Comment 5

10 years ago
Created attachment 312714 [details] [diff] [review]
Added TB version, too.

Carrying over r+
Attachment #311772 - Attachment is obsolete: true
Attachment #312714 - Flags: superreview?(neil)
Attachment #312714 - Flags: review+
(Assignee)

Updated

10 years ago
Attachment #312714 - Flags: review?(philringnalda)
(Assignee)

Updated

10 years ago
Severity: normal → trivial
Comment on attachment 312714 [details] [diff] [review]
Added TB version, too.

r=me, thanks
Attachment #312714 - Flags: review?(philringnalda) → review+

Updated

10 years ago
Attachment #312714 - Flags: superreview?(neil) → superreview+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Assignee: mail → prometeo.bugs
Checking in suite/locales/en-US/chrome/mailnews/pref/am-offline.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/pref/am-offline.dtd,v  <--  am-offline.dtd
new revision: 1.12; previous revision: 1.11
done
Checking in mail/locales/en-US/chrome/messenger/am-offline.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/am-offline.dtd,v  <--  am-offline.dtd
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Status: RESOLVED → VERIFIED
(Assignee)

Comment 8

10 years ago
Verified with build id: 2008040501
You need to log in before you can comment on or make changes to this bug.