425221 - please QA the Awards page on the new Mozilla.com

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[John Slater]

Hi Stephen. Please QA as discussed. One thing that immediately jumps out at me is that it would be really nice if the images of the Thunderbird awards could line up more evenly with the top of that section.

Also, it would be great if the images of the awards were clickable just like the text descriptions.

Thanks,
John

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

1) I agree with John: it'd be nice to see the award images clickable.  If we do that, can we please use TITLE attributes?
2) There's a _lot_ of vertical whitespace in the "Thunderbird Awards" section between the title/text block and its borders; can we tighten that up a bit?

Note to self: page validates and is fine with JS disabled.

Comment 2

[Marco Zehe (:MarcoZ)]

Is it intentional that with the Thunderbird awards, the list containing the award graphics follows the list with the actual textual information, whereas with Firefox it's the other way around? "Feels" a bit inconsistent. Other than that, a11y looks fine.

Comment 3

[John Slater]

(In reply to comment #2)
> Is it intentional that with the Thunderbird awards, the list containing the
> award graphics follows the list with the actual textual information, whereas
> with Firefox it's the other way around? "Feels" a bit inconsistent. Other than
> that, a11y looks fine.
Marco, I'm sorry to be dense here but I'm not following you. Could you explain further?

Comment 4

[Marco Zehe (:MarcoZ)]

(In reply to comment #3)
> (In reply to comment #2)
> > Is it intentional that with the Thunderbird awards, the list containing the
> > award graphics follows the list with the actual textual information, whereas
> > with Firefox it's the other way around? "Feels" a bit inconsistent. Other than
> > that, a11y looks fine.
> Marco, I'm sorry to be dense here but I'm not following you. Could you explain
> further?

Here's the output I get from my screen reader. The stuff in square brackets is additional information spoken, but not actually visible on screen.

Firefox Awards [heading level 2]
[List of 8 items]
[graphic]Red Herring 100 Winner, 2007
[graphic]PC Pro Software of the Year, 2007
[graphic]Abril Info Award, Software of the Year, Dec 2007
{...}
[List End]
[List of 30 items]
[link]Red Herring Global 100
, December 2007
[link]PC Pro Software of the Year
, December 2007
[link]Abril Info Award, Software of the Year
, December 2007
{...}
[List End]

Thunderbird Awards [Heading level 2]
[List of 4 items]
[link]TUX 2005 Readers' Choice Award
, September 2005
[link]PC World, Top 100 Best Product
, June 2005
[link]Technology & Business magazine Editors’ Choice
[link]Softpedia Pick: 5/5
[List End]
[List of 3 items]
[graphic]TUX 2005 Readers' Choice Award
[graphic]ZDnet award
[graphic]Softpedia Pick award
[List End]

As you can see, the information for Thunderbird is reversed: Links first, graphics afterwards. When reading this top to bottom, it simply leaves kind of an inconsistent impression.

Comment 5

[Steven Garrity [:sgarrity]]

Alignment issues, page order issues, are fixed - award images are linked in r11749 and r11750.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

3) There are now 15 validation errors.
4) I really don't know what I was thinking with the second part of comment 2, about there being a lot of "vertical whitespace," so cheerfully ignore that :-)

If this is fine with Marco, and once the validation errors have been fixed, please mark it Fixed and I'll happily verify; thanks!

Comment 7

[Steven Garrity [:sgarrity]]

Validation errors fixed in r11777.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> Validation errors fixed in r11777.

I get 32 validation errors, most of which show up as unbalance <li> tags (but also a couple mismatched <h2> and <ul> tags?)

Comment 9

[Steven Garrity [:sgarrity]]

32 validation errors from one typo. Fixed in r12011. Thanks.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #9)
> 32 validation errors from one typo. Fixed in r12011. Thanks.

Verified FIXED