42529 - Bugzilla reports: radios don't change when updating Resolution

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Eric Pollmann]

When setting the resolution of a bug in Bugzilla (e.g. FIXED), the radio to the 
left of the resolution combo box should be automatically checked.  This does not 
happen.  Rod already did some preliminary investigation and determined that the 
combo box is firing an onchange, so the cause is probably that refering to an 
element in an array of radios isn't working.

Comment 1

[Blake Ross]

seems somehow related to bug 40571, though that's been fixed for about 2 weeks 
now

Comment 2

[Eric Pollmann]

I cooked up a test case to test the first hypothesis and it works fine, so I 
went back to the original page.  I get this on the console when changing the 
Resolution select:

JavaScript error:
 line 0: document.changeform.knob has no properties

So for some reason knob is not accessible as a property of changeform.  I'm 
still looking into this.

Comment 3

[Eric Pollmann]

This seems to work when the form is a container, but not when it is a leaf node.  
for example, this works:

<FORM>
 <INPUT TYPE=radio NAME=knob VALUE=resolve>
 <BUTTON ONCLICK="form.knob.checked=true;">Check</BUTTON>
</FORM>

But this does not (simply insert a <P> before </FORM>)

<FORM>
 <INPUT TYPE=radio NAME=knob VALUE=resolve>
 <BUTTON ONCLICK="form.knob.checked=true;">Check</BUTTON>
 <P>
</FORM>

The fact that the form is not correctly nested and has to be demoted to a leaf 
node also causes the bugzila bug page to take about twice as long to lay out as 
it would if it were correctly nested.  We should fix this in bugzilla too.

Comment 4

[Hixie (not reading bugmail)]

Erm, <P> is perfectly valid inside <FORM>, as is pretty much everything else
except FORM itself:
 
   <!ELEMENT FORM - - (%block;|SCRIPT)+ -(FORM) -- interactive form -->

Comment 5

[Eric Pollmann]

See also bug 42675.

Comment 6

[Eric Pollmann]

Ian - interesting point, and </p> is optional, so why are we demoting this form 
to be a leaf node?  I don't know the specifics on how this decision to demote or 
not is made...

Comment 7

[Johnny Stenback (:jst)]

I have a fix for the problem that form controls can't always be accessed after
we've demoted a form to be a leaf node, and the reason we do that is coverd by
bug 42312.

Comment 8

[Eric Pollmann]

Great, that's exactly the problem.  I'm giving this to you so you can close it 
out when you checkin that fix.  Thanks!

Comment 9

[Johnny Stenback (:jst)]

I checked in my fix today, closing this bug.

Comment 10

[Prashant Desale]

Verified with 2000-07-07-10.