425431 - Update wikipedia search engine

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Emil Ivanov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032705 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032705 Minefield/3.0pre

Wikipedia is in the default search engine list with name Wikipedia (English)
The search engine from wikipedia site is Wikipedia (en)

Reproducible: Always

Steps to Reproduce:
1. Search for something via searchbar and select wikipedia
2. Go to the wikipedia site
3. See the search engine dropdown arrow
Actual Results:  
It is possible to install the wikipedia search engine when wikipedia is already installed by default

Comment 1

[Axel Hecht [:Pike]]

Yeah, most of the localized ones have this already fixed, but en-US not yet.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Wikipedia has changed the format they use for their plugin names since we added the engine. I think they've settled on a common pattern now. We should take this change to avoid users with the plugin being prompted to install another when they visit wikipedia.

This has no l10n impact, because localizers already have their own localized wikipedia plugins (and have had to deal with this same problem themselves).

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 312051 [details] [diff] [review]
patch

r=me.

Comment 4

[Emil Ivanov]

There is option to update search engines in
Tools > Options > Adavnced > Update

Is it working?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> There is option to update search engines in
> Tools > Options > Adavnced > Update
> 
> Is it working?

Yes, but not for app-shipped search plugins. Those are updated when we update the application.

Comment 6

[Emil Ivanov]

So if a default search engine is updated on a site, it will stay not updated in the app because there wont be pushed release only for this. This is not very flexible, but guess you rely on that the search engines are rarely changed.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> So if a default search engine is updated on a site, it will stay not updated in
> the app because there wont be pushed release only for this. This is not very
> flexible, but guess you rely on that the search engines are rarely changed.

Yes.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/searchplugins/wikipedia.xml 	1.2 

Comment 9

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008033004 Minefield/3.0pre.