425484 - upload breakpad symbols for mozilla 2 builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[(not currently active) Ted Mielczarek]

We need this for 1.9 parity.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: sub-env for moz2 symbols

Comment 2

[[e-mail] (:bhearsum)]

Attachment: turn on symbol uploading for mozilla-central

AFAICT we'll only be able to do symbols for one branch at a time with the current setup. Ted, you mentioned something about being able to supply an extra string. Maybe we can use that in the future, if we need to.

Comment 3

[(not currently active) Ted Mielczarek]

You can set MOZ_SYMBOLS_EXTRA_BUILDID to any sort of string (that will work in a filename). We've used this in the past when we were doing builds off of the textframe branch.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: one more time, with feeling

Sorry, got a little excited when doing this and forgot that Moz2 environments are in the config file.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 314148 [details] [diff] [review]
one more time, with feeling

We shouldn't use EXTRA_BUILDID on mozilla-central. That's analogous to CVS trunk, which isn't using one either. It's the main line of development, so it doesn't need any extra specification. Stuff like actionmonkey should use it, however.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: [checked in] patch as landed (don't use MOZ_SYMBOLS_EXTRA_BUILDID for mozilla-central)

changeset:   21:291fc58a2200
tag:         tip
user:        Ben Hearsum <[e-mail]>
date:        Wed Apr 09 08:20:39 2008 -0400
files:       mozilla2/master.cfg

Comment 7

[[e-mail] (:bhearsum)]

Attachment: last little bits

I did some tests on Mac and Win32 and noticed that not much actually being stored. I updated the mozconfigs with the lines found here: http://developer.mozilla.org/en/docs/Building_Firefox_with_Debug_Symbols

I also had to hardcode the path to the ssh key -- ${HOME} doesn't work from within Buildbot (ssh will literally end up looking for '${HOME}/.ssh/...').

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 314605 [details] [diff] [review]
last little bits

>diff -r ac56a25e6126 mozilla2/macosx/mozconfig
>--- a/mozilla2/macosx/mozconfig	Wed Apr 09 09:42:55 2008 -0400
>+++ b/mozilla2/macosx/mozconfig	Wed Apr 09 11:38:44 2008 -0400
>@@ -4,3 +4,6 @@ ac_add_options --enable-application=brow
> ac_add_options --enable-application=browser
> ac_add_options --enable-update-packaging
> ac_add_options --disable-tests
>+
>+export CFLAGS="-g -gfull"
>+export CXXFLAGS="-g -gfull"

This is 10.5, right? This needs to be -gstabs -gfull. Then again, we'll probably run into some stupid problems with this. Might need to touch base with Nick to recall how we worked around this?

>diff -r ac56a25e6126 mozilla2/win32/mozconfig
>--- a/mozilla2/win32/mozconfig	Wed Apr 09 09:42:55 2008 -0400
>+++ b/mozilla2/win32/mozconfig	Wed Apr 09 11:38:44 2008 -0400
>@@ -1,3 +1,6 @@ ac_add_options --enable-application=brow
> ac_add_options --enable-application=browser
> ac_add_options --enable-update-packaging
> ac_add_options --enable-jemalloc
>+
>+export MOZ_DEBUG_SYMBOLS=1
>+ac_add_options --enable-debugger-info-modules=yes

--enable-debugger-info-modules is redundant with MOZ_DEBUG_SYMBOLS. Drop the second line.

Comment 9

[[e-mail] (:bhearsum)]

Attachment: [checked in] same as before w/ -save-temps on mac to make the build work with gstabs

changeset:   23:72f4cdc836f1
tag:         tip
user:        Ben Hearsum <[e-mail]>
date:        Wed Apr 09 14:11:38 2008 -0400
files:       mozilla2/linux/mozconfig mozilla2/macosx/mozconfig mozilla2/master.cfg mozilla2/win32/mozconfig

Comment 10

[[e-mail] (:bhearsum)]

-save-temps on mac eats up a *ton* of space - we're going to need to solve that in some way if we add anymore branches. This is working...sortof. Ted says there's a visibility issue with the crash report/symbols, here's an example: http://crash-stats.mozilla.com/report/index/08cae0d7-06fc-11dd-85ea-001b78bc73ea

This bug is fixed...but we should be moving to dwarf symbols on OS X in the future to combat excessive disk space usage, as well as have proper symbols on mac

Comment 11

[[e-mail] (:bhearsum)]

Attachment: [checked in] cleanup many temp files after OS x builds

Comment 12

[Benjamin Smedberg]

Comment on attachment 314873 [details] [diff] [review]
[checked in] cleanup many temp files after OS x builds

r=me with extraneous "% OBJDIR" removed per IRC

Comment 13

[[e-mail] (:bhearsum)]

Comment on attachment 314873 [details] [diff] [review]
[checked in] cleanup many temp files after OS x builds

changeset:   26:8b793cd1c1e9
tag:         tip
user:        Ben Hearsum <[e-mail]>
date:        Fri Apr 11 10:16:07 2008 -0400
files:       mozilla2/master.cfg