425640 - Bad check-in in nsBrowserGlue

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

where are those + coming from? feels like an interdiff check-in

http://lxr.mozilla.org/seamonkey/source/browser/components/nsBrowserGlue.js#402

402 
403     if (!importBookmarks) {
404 +     /**
405 +      * These prefs are set by the backend services upon creation (or recreation)
406 +      * of the Places db:
407 +      * - browser.places.importBookmarksHTML
408 +      *   Set to false by the history service to indicate we need to re-import.
409 +      * - browser.places.createdSmartBookmarks
410 +      *   Set during HTML import to indicate that the queries were created.
411 +      */
412       // Call it here for Fx3 profiles created before the Places folder
413       // has been added, otherwise it's called during import.
414       this.ensurePlacesDefaultQueriesInitialized();
415     }

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch

Comment 2

[Marco Bonardo [:mak]]

humm but probably that comment shouldn't be there at all

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch

mh, better

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 312249 [details] [diff] [review]
patch

gah. thanks.

Comment 5

[Dietrich Ayala (:dietrich)]

Checking in browser/components/nsBrowserGlue.js;
/cvsroot/mozilla/browser/components/nsBrowserGlue.js,v  <--  nsBrowserGlue.js
new revision: 1.84; previous revision: 1.83
done

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv