425684 - [fr] Update Wikipedia searchplugin to match title

Status: VERIFIED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Axel Hecht [:Pike]]

Wikipedia changed their site to say (ab-CD), mind creating a patch to reflect that?

You can find the exact title by going to http://fr.wikipedia.org/, view source, find the rel="search" link and pick its title.

"Wikipédia (Français)" should be "Wikipédia (fr)" according to my latest check.

Comment 1

[Cédric Corazza]

Attachment: Patch for wikipedia-fr

Comment 2

[Axel Hecht [:Pike]]

Actually, could we get this even closer to match http://mxr.mozilla.org/mozilla/source/browser/locales/en-US/searchplugins/wikipedia.xml?

I.e., add suggest URL and use http://fr.wikipedia.org/wiki/Special:Recherche in both the regular search Url as in SearchForm?

en-US still has a broken ShortName, so that's not to clone.

Comment 3

[Cédric Corazza]

Attachment: Patch for wikipedia-fr - v2

Philippe, if this is ok for you, please ask for approval1.9? and approval1.8.1.14?
Thanks

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 312462 [details] [diff] [review]
Patch for wikipedia-fr - v2

I can't grant approval1.9 just yet, please add my review to the check-in comment for trunk landing.

For the branch, request approval1.8.1.14, though.

Comment 5

[Cédric Corazza]

Comment on attachment 312462 [details] [diff] [review]
Patch for wikipedia-fr - v2

Checking in browser/searchplugins/wikipedia-fr.xml;
/l10n/l10n/fr/browser/searchplugins/wikipedia-fr.xml,v  <--  wikipedia-fr.xml
new revision: 1.6; previous revision: 1.5
done. 
FIXED on trunk. I will ask for approval1.8.1.14 once this is verified on trunk

Comment 6

[Cédric Corazza]

Comment on attachment 312462 [details] [diff] [review]
Patch for wikipedia-fr - v2

VERIFIED on trunk.
Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9pre) Gecko/2008032907 Minefield/3.0pre

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 312462 [details] [diff] [review]
Patch for wikipedia-fr - v2

approval for 1.8 branch granted. keywords, check-in comments, you french folks know, I know.

Comment 8

[Cédric Corazza]

Checking in browser/searchplugins/wikipedia-fr.xml;
/l10n/l10n/fr/browser/searchplugins/wikipedia-fr.xml,v  <--  wikipedia-fr.xml
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Comment 9

[Cédric Corazza]

Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.14pre) Gecko/20080329 BonEcho/2.0.0.14pre