425686 - [he] Update Wikipedia searchplugin to match title

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Axel Hecht [:Pike]]

Wikipedia changed their site to say (ab-CD), mind creating a patch to reflect that?

You can find the exact title by going to http://he.wikipedia.org/, view source, find the rel="search" link and pick its title.

"ויקיפדיה (עברית)‏" should be "ויקיפדיה (he)" according to my latest check.

Comment 1

[Tomer Cohen :tomer]

Are you sure we most change it? Keep in mind that no one know about "he" while the language name in that language is much more readable. 

Adding English text will also make the parenthesis jump to the other side, which will also reopen bug 415976.  

Comment 2

[Axel Hecht [:Pike]]

As long as we don't take their title, firefox will claim that there's a plugin for he.wikipedia.org that can still be installed.

If that's bad layout-wise, we should probably try to file a bug on wikipedia.

Do we know what IE does for their plugin?

Comment 3

[Tomer Cohen :tomer]

I'm not sure if Internet Explorer has *Hebrew* search plugin for Wikipedia. 

Comment 4

[Axel Hecht [:Pike]]

But you should be able to add it when going to http://he.wikipedia.org/, I would hope? I'm avoided the blue e like the plague it is, so I don't know.

Comment 5

[Tsahi Asher]

(In reply to comment #4)
> But you should be able to add it when going to http://he.wikipedia.org/, I
> would hope?
> 
yes, you can. and it shows ויקיפדיה (he).

Comment 6

[Axel Hecht [:Pike]]

Can you try what happens with their plugin and our UI?

Comment 7

[Tsahi Asher]

with ff3b4 rtl, it looks not bad. it looks like [(he) ויקיפדיה] in the search box. i assume that in a ltr firefox it will look like in comment 5 above.

however, i do agree with tomer though, that users won't understand what is the "(he)" about.

Comment 8

[Tomer Cohen :tomer]

Attachment: screenshot of he.wikipedia.org on RTL firefox

I agree with Axel about the requirement to use the same title as Wikipedia, and with Tsahi about the non informative "(he)" in the plugin title. Maybe we should ask Wikipedia to change it. In the meantime I'll update the plugin on our repository. 

Attached a screenshot of he.wikipedia.org plugin in Firefox3b4-hebrew.

Comment 9

[Axel Hecht [:Pike]]

CCing Brion Vibber.

Brion, I hope you don't mind too much, can you help us out here a little?

Brion fixed https://bugzilla.wikimedia.org/show_bug.cgi?id=12723, which added the (ab-CD) after the wikipedia local name, in bytestream order.

Brian, any suggestion on how to fix the mixed RTL/LTR code, is there something we could/should do on the wikipedia side of things? This probably not only affects Hebrew, but Arabic and Persian, too.

Comment 10

[Axel Hecht [:Pike]]

Tomer, please put a patch for that in my review queue before checking in?

Comment 11

[Tomer Cohen :tomer]

Attachment: diff

The attached file is the same as the one on Wikipedia. In the past I've changes it a bit to make it MozSearch but I think it is not required any more as it has the suggestions already.

Comment 12

[Tomer Cohen :tomer]

Attachment: http://he.wikipedia.org/w/opensearch_desc.php

Comment 13

[Brion Vibber]

We're using the language code because language names are too long -- the OpenSearch standard imposes a draconianly short name length limit of 16 characters on the ShortName, which is what Firefox seems to use after you've added a search engine to the list. (It uses the full name for the "add" link, which is even more confusing!)

If we include the language name in the short name, then we break the standard 99% of the time.

If we have different short and long name, then the UI is inconsistent -- and the short name will be the one that people are forced to see when they actually use it.

If we remove the language entirely, then people who search in multiple languages won't be able to keep track of what they are (in most languages, Wikipedia's local name is... Wikipedia.)

It's a danged if you do, danged if you don't situation. :)

Now, in the particular case, Hebrew Wikipedian admins could customize the name if they choose. Since the Hebrew name is already quite unique -- being in Hebrew script -- the language bit could perhaps be removed without loss of information.

What I'd rather get, though, is confirmation that the ShortName length limit in the OpenSearch spec is safe to ignore, and we can go back to using legible names.

Comment 14

[Axel Hecht [:Pike]]

Hi Brion, thanks for your input.

Sadly, I can't grant you permission to ignore the spec, more so as it's really not ours. And you might want to stay interoperable with IE, after all ;-)

Guess it'd be a good idea to get in touch with the Hebrew admins, how would one do that? Never had to do that before, though Mic might know, too.

Comment 15

[Tsahi Asher]

the bureaucrat of the hebrew wikipedia is david shay. according to his user page, his email is shayde at 012.net.il.

Comment 16

[Tomer Cohen :tomer]

Attachment: MozSearch plugin

Axel said we would better stick with MozSearch (What the point? I have no clue), so I've created a new patch.


I've contacted David and requested his opinion about our issue.

Comment 17

[Tomer Cohen :tomer]

Attachment: wikipedia-he.xml MozSearch plugin

Comment 18

[Rotem Liss]

I changed the description of the OpenSearch page in Hebrew Wikipedia not to include the language.

Comment 19

[Axel Hecht [:Pike]]

Very cool, thanks for that.

 "ויקיפדיה (עברית)‏" should be "ויקיפדיה" then in our plugin.

Comment 20

[Tomer Cohen :tomer]

Attachment: diff wikipedia-he.xml (fixed par comment 18)

(In reply to comment #19)
>  "ויקיפדיה (עברית)‏" should be "ויקיפדיה" then in our
> plugin.

Done. Please review.


Rotemliss: Thanks for your help.

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 312627 [details] [diff] [review]
diff wikipedia-he.xml (fixed par comment 18) 

r=me, with one nit, please put the ShortName into a separate line?

Please check in with a comment referencing this bug and my review.

Comment 22

[Tomer Cohen :tomer]

Done. Revision 1.5.