425704 - [ro] Update Wikipedia searchplugin to match title, add search suggest etc

Status: RESOLVED FIXED

(Mozilla Localizations :: ro / Romanian, defect)

Description

[Axel Hecht [:Pike]]

Wikipedia changed their site to say (ab-CD), mind creating a patch to reflect that?

You can find the exact title by going to http://ro.wikipedia.org/, view source, find the rel="search" link and pick its title.

"Wikipedia în Română" should be "Wikipedia (ro)" according to my latest check.

Comment 1

[Axel Hecht [:Pike]]

Actually, can we get a bigger overhaul?

Up to the ShortName, could you adopt the format and features/icon from http://mxr.mozilla.org/mozilla/source/browser/locales/en-US/searchplugins/wikipedia.xml?raw=1 ? Then you'd have search suggest as well etc.

Please attach a patch and request review from me on it before checking in.

Comment 2

[Axel Hecht [:Pike]]

Alexandru, can you please create a patch for this?

Sorry for not making sure that you'd actually get bugmail for these earlier.

Comment 3

[Alexandru Szasz]

Attachment: update for wikipedia search plugin - Romanian

I updated the plugin from the en-US plugin, I guess the icon is the same no matter what language.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 314185 [details] [diff] [review]
update for wikipedia search plugin - Romanian

Looking good, r=me.

Please check it in with a review comment referencing this comment and my review, and a description of the change.

Comment 5

[Axel Hecht [:Pike]]

FIXED, thanks.