Last Comment Bug 425707 - Move low-level spelling code to a CHBrowserView category
: Move low-level spelling code to a CHBrowserView category
Product: Camino Graveyard
Classification: Graveyard
Component: General (show other bugs)
: unspecified
: x86 Mac OS X
-- normal (vote)
: Camino2.0
Assigned To: Stuart Morgan
Depends on:
  Show dependency treegraph
Reported: 2008-03-28 08:22 PDT by Stuart Morgan
Modified: 2008-03-31 09:18 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

move spelling code (47.13 KB, patch)
2008-03-28 08:22 PDT, Stuart Morgan
mikepinkerton: superreview+
Details | Diff | Splinter Review

Description User image Stuart Morgan 2008-03-28 08:22:22 PDT
Created attachment 312282 [details] [diff] [review]
move spelling code

This pulls all the Gecko spelling code into a category on CHBrowserView. It gets a bunch of low-level code out of BWC (double-win!), and lets us hide a few Gecko internals that were previously in public CHBrowserView methods (while I was moving the now-hidden declarations, I changed the methods to use already_AddRefed to make them less error-prone).

I don't think this is the ideal place for this code long-term (having browser view methods that operate on the current text insertion point is somewhat odd), but it's a big improvement over where it was without having to create a whole set of wrappers for various Gecko page elements--and now that it's separated into a self-contained chunk, it would be easy to move around again later. I do think it belongs at the CH layer, which is why it's there as opposed to a BWC category.
Comment 1 User image Mike Pinkerton (not reading bugmail) 2008-03-31 08:23:38 PDT
Comment on attachment 312282 [details] [diff] [review]
move spelling code

Comment 2 User image Stuart Morgan 2008-03-31 09:18:29 PDT
Landed on trunk.

Note You need to log in before you can comment on or make changes to this bug.