Move low-level spelling code to a CHBrowserView category

RESOLVED FIXED in Camino2.0

Status

Camino Graveyard
General
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

unspecified
Camino2.0
x86
Mac OS X

Details

Attachments

(1 attachment)

47.13 KB, patch
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Created attachment 312282 [details] [diff] [review]
move spelling code

This pulls all the Gecko spelling code into a category on CHBrowserView. It gets a bunch of low-level code out of BWC (double-win!), and lets us hide a few Gecko internals that were previously in public CHBrowserView methods (while I was moving the now-hidden declarations, I changed the methods to use already_AddRefed to make them less error-prone).

I don't think this is the ideal place for this code long-term (having browser view methods that operate on the current text insertion point is somewhat odd), but it's a big improvement over where it was without having to create a whole set of wrappers for various Gecko page elements--and now that it's separated into a self-contained chunk, it would be easy to move around again later. I do think it belongs at the CH layer, which is why it's there as opposed to a BWC category.
Attachment #312282 - Flags: superreview?(mikepinkerton)
Comment on attachment 312282 [details] [diff] [review]
move spelling code

sr=pink
Attachment #312282 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 2

9 years ago
Landed on trunk.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.