Unified Queries are not yet implemented, but the idl is hiding the fact.

RESOLVED FIXED in Firefox 3.7a1

Status

()

Firefox
Bookmarks & History
P2
normal
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: cmtalbert, Assigned: mak)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 3.7a1
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 -

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

9 years ago
Created attachment 312292 [details]
Specific test for this issue

When performing a unified query over a set of history and bookmarks, the returned resultNode object is not properly contructed. the hasChildren attribute is set to true, but when you attempt to access any of those children or if you even access childCount you get the following exception thrown:
Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsINavHistoryContainerResultNode.childCount]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: ../../../../_tests/xpcshell-simple/test_places/queries/test_onlybookmark-tags-unified.js :: run_test :: line 137"  data: no]

I will attach a test for this behavior.

Basic STR:
1. Create a database with information in both history and bookmarks
2. Query for that with a UNIFIED query.
3. Loop through the ContainerResultNode object and display all the information you queried for.

== Expected == 
Proper ResultNode object returned

== Actual ==
ResultNode object that is returned seems mis-constructed.
(Reporter)

Comment 1

9 years ago
Created attachment 312293 [details]
header file for test
(Reporter)

Comment 2

9 years ago
This seems like a pretty serious flaw, nominating for blocking.
Flags: blocking-firefox3?
Priority: -- → P2
Target Milestone: --- → Firefox 3
not implemented. should not be exposed in the idl. was to support bug 378798, which is blocking-.
Blocks: 378798
This does not block the final release of Firefox 3.
Flags: blocking-firefox3? → blocking-firefox3-
(Reporter)

Comment 5

9 years ago
(In reply to comment #3)
> not implemented. should not be exposed in the idl. was to support bug 378798,
> which is blocking-.
> 
I saw that bug, but I read it as "unified queries are not going to be exposed in the UI". Sorry for duping it.

Can we use this bug to land a fix that comments out that part of the IDL? 

The option is not used in any critical code:
http://mxr.mozilla.org/mozilla/search?string=QUERY_TYPE_UNIFIED
Target Milestone: Firefox 3 → ---
(Assignee)

Updated

8 years ago
Blocks: 509868
(Assignee)

Updated

8 years ago
Summary: Unified Query does not create proper ResultNode object → Unified Queries are not yet implemented, but the idl is hiding the fact.
(Assignee)

Comment 6

8 years ago
Created attachment 395687 [details] [diff] [review]
patch v1.0

i just added 2 comments, to avoid idl and uuid changes.
LEt me know if you want to comment them out and update uuid instead.
Assignee: nobody → mak77
Attachment #312292 - Attachment is obsolete: true
Attachment #312293 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #395687 - Flags: review?(dietrich)
Comment on attachment 395687 [details] [diff] [review]
patch v1.0

hrm. yeah, better than breaking compat for this, r=me.
Attachment #395687 - Flags: review?(dietrich) → review+
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/6f223f020757
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
(Assignee)

Comment 9

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2347779112f9
status1.9.2: --- → beta1-fixed
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.