425845 - Treehydra: Clean up libraries for strict mode

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[David Mandelin [:dmandelin]]

Attachment: strict mode patch

Currently even just importing treehydra.js and system.js gives a bunch of warnings in strict mode. Probably, we would prefer to have it not do that. I should mention that none of the warnings is an actual fault in the code, but it will make it difficult to use strict mode unless the libs are clean.

I attached a patch I used that's a starting point for this.

Comment 1

[(dormant account)]

Comment on attachment 312405 [details] [diff] [review]
strict mode patch

> GCCNode.prototype.__defineGetter__("name", function () {
>   if (DECL_P (this))
>     return decl_name(this)
>+  throw new Error(".name not implemented for other than DECLs");
> })
> 
> 


I was gonna complain against this, but on second thought, looks good

Comment 2

[David Mandelin [:dmandelin]]

Attachment: Patch updated for current Treehydra

Comment 3

[David Mandelin [:dmandelin]]

Attachment: Small revision to make VEC_iterate more convenient

This makes VEC_iterate more convenient, and also makes it match the original semantics better.

Comment 4

[(dormant account)]

Comment on attachment 317128 [details] [diff] [review]
Small revision to make VEC_iterate more convenient

> function VEC_iterate (vec_node) {
>-  if (vec_node)
>-    return vec_node.base.vec
>+  // undefined is used for empty vectors, so support it nicely here.
>+  return vec_node ? vec_node.base.vec : [];
> }

I'm not sure if this is the correct place to put it. Seems that convenience changes to GCC GIMPLE behavior should be added similarly to GCCNode.prototype.operands

Comment 5

[David Mandelin [:dmandelin]]

Comment on attachment 317128 [details] [diff] [review]
Small revision to make VEC_iterate more convenient

Cleaning up ancient review requests.

Comment 6

[Joshua Cranmer [:jcranmer]]

Dehydra and treehydra are no longer maintained by Mozilla.