Closed Bug 425856 Opened 12 years ago Closed 10 years ago

Add shortcut to focus search field in "Get Add-ons" panel

Categories

(Toolkit :: Add-ons Manager, enhancement)

enhancement
Not set

Tracking

()

VERIFIED INVALID

People

(Reporter: whimboo, Unassigned)

References

Details

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5

Users who open the "Get Add-ons" panel, are trying to find a specific add-on. With the current implementation they have to manually set the focus to the search field before they can enter the add-ons name. IMO this should get a higher priority as the list of recommended add-ons. The latter one will be interesting for new users but manually placing the focus into the search field will bother experienced users.

If the focus is placed in the search field per default the self-describing text will not be visible. But is it important for the user? Doesn't the magnifying glas identify this text field as a search field? What else should the user enter here?
Blocks: 404024
Product: Firefox → Toolkit
If we do this then it hides the "Search All Add-ons" grey text in the search box, however given that you have clicked on the get add-ons header the focus is there and not in the main list as it is which is kinda faily anyway.

Any thoughts Boriss?
Keywords: uiwanted
Severity: normal → enhancement
Henrik - I definitely agree with you that the search box should get focus.  

My initial worry was whether having the search field search the AMO directory, rather than the list of recommended add-ons that appears below it, would break OS consistency and be confusing.  But after looking at a few examples, I'm no longer worried it's an issue.  These search boxes in windows of OSX and Windows do computer-wide searches, and even the Google search box in Firefox is obviously searching more than the current page.  Given there's no expectation apparently being violated, I agree with you that the magnifying glass should be enough, and adding text to the chrome outside of the search box would be unnecessary.

So yeah, my vote is to give the search box focus.  Anyone else have thoughts on this?
Blocks: 465492
No longer blocks: 404024
I miss the autofocus on the search field too.
Wouldn't that easy to fix? Dao?
Not sure if it's intentional, but it seems ironic to me that this blocks bug 458867 :). Seems like this would break cycling through the views with the keyboard, unless you focus the search field only when the window is opened. But then 'users who open the "Get Add-ons" panel' doesn't really apply, because they really open the Add-ons Manager, and it's not clear what they're going to do.
Oh, that's true. So why we don't give this search textbox a keyboard shortcut? All the other windows/dialogs offer to focus the box with Cmd/Ctrl+F. I think that would help a lot. Personally I would be satisfied with this solution.
(In reply to comment #5)
> Not sure if it's intentional, but it seems ironic to me that this blocks bug
> 458867 :). Seems like this would break cycling through the views with the
> keyboard, unless you focus the search field only when the window is opened.

Wholly intentional so that I would remember that this has an impact on focus in the add-ons manager :)

I think I agree though doing this is going to harm the better focus behaviour that we end up with from bug 397986.(In reply to comment #6)

> Oh, that's true. So why we don't give this search textbox a keyboard shortcut?
> All the other windows/dialogs offer to focus the box with Cmd/Ctrl+F. I think
> that would help a lot. Personally I would be satisfied with this solution.

That seems a reasonable compromise, not terribly discoverable but I guess it is a standard shortcut
Slightly modifying summary to reflect latest statements.
Summary: Focus in "Get Add-ons" panel should be set to the search field when panel is opened → Add shortcut to focus search field in "Get Add-ons" panel
This is gone in the new UI. bug 570760 covers its replacement.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.