Closed Bug 426004 Opened 14 years ago Closed 14 years ago

Style the site button to mirror the keyhole form on Vista

Categories

(Firefox :: Theme, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: faaborg, Assigned: dao)

References

Details

Attachments

(1 file)

This is a spin off bug of bug 414183 to add the following lines to browser-aero.css (or however we plan to do vista specific themeing with chrome overrides).

/*margin: -4px 0;
+  padding: 3px 2px 3px 4px;
+  background-position: 0 3px;
+  -moz-border-radius-topleft: 14px;
+  -moz-border-radius-bottomleft: 14px;*/
Flags: blocking-firefox3?
Are these any different than the XP ones?
the radius is different. the vista code is currently commented out in winstripe's browser.css. someone with cvs access needs to copy it to browser-aero.css.
>Are these any different than the XP ones?

the site button should be a mirror image of the curve on the forward button.  If we don't land this CSS, then we have to contact the Iconfactory to do a lot of additional image work.
Blocks: 405605
Flags: blocking-firefox3? → blocking-firefox3+
Attached patch patchSplinter Review
Similar to attachment 313913 [details] [diff] [review], we can use browser.css as the basis for browser-aero.css. This means though that browser-aero.css will contain some useless rules (i.e. the overridden ones).
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #314172 - Flags: review?(gavin.sharp)
Attachment #314172 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/browser-aero.css,v
done
Checking in browser/themes/winstripe/browser/browser-aero.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser-aero.css,v  <--  browser-aero.css
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.194; previous revision: 1.193
done
Checking in browser/themes/winstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.85; previous revision: 1.84
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.