426004 - Style the site button to mirror the keyhole form on Vista

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

This is a spin off bug of bug 414183 to add the following lines to browser-aero.css (or however we plan to do vista specific themeing with chrome overrides).

/*margin: -4px 0;
+  padding: 3px 2px 3px 4px;
+  background-position: 0 3px;
+  -moz-border-radius-topleft: 14px;
+  -moz-border-radius-bottomleft: 14px;*/

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Are these any different than the XP ones?

Comment 2

[Dão Gottwald [:dao]]

the radius is different. the vista code is currently commented out in winstripe's browser.css. someone with cvs access needs to copy it to browser-aero.css.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>Are these any different than the XP ones?

the site button should be a mirror image of the curve on the forward button.  If we don't land this CSS, then we have to contact the Iconfactory to do a lot of additional image work.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Similar to attachment 313913 [details] [diff] [review], we can use browser.css as the basis for browser-aero.css. This means though that browser-aero.css will contain some useless rules (i.e. the overridden ones).

Comment 5

[Reed Loden [:reed]]

RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/browser-aero.css,v
done
Checking in browser/themes/winstripe/browser/browser-aero.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser-aero.css,v  <--  browser-aero.css
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.194; previous revision: 1.193
done
Checking in browser/themes/winstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.85; previous revision: 1.84
done