Closed
Bug 426079
Opened 16 years ago
Closed 15 years ago
[Win][Linux] Print Preview toolbar not shown if launched from window without toolbar
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.6a1
People
(Reporter: MattN, Assigned: MattN)
Details
Attachments
(1 file, 1 obsolete file)
1.06 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4 A window was opened from a webpage using javascript without the feature 'toolbar' set to yes. i.e. window.open('http://www.google.ca','_blank','menubar=yes'); When I then went to Print Preview (File->Print Preview), the print preview toolbar was missing. NTOE: Opening a window with 'toolbar=yes' does not have this problem. i.e. window.open('http://www.google.ca','_blank','menubar=yes,toolbar=yes'); Reproducible: Always Steps to Reproduce: 1. Open a new browser window through javascript using window.open('http://www.google.ca','_blank','menubar=yes'); 2. Click File->Print Preview Actual Results: The print preview screen appears but there is no toolbar Expected Results: The print preview screen should have shown the toolbar with the buttons such as "Print...", "Page Setup...", etc. HTML Testcase: <a onclick="window.open('http://www.google.ca','_blank','menubar=yes');">Open Popup</a>
Assignee | ||
Comment 1•16 years ago
|
||
I just wanted to update this bug to say that it is still present in Firefox 3 RC1 (2008051206)
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2a1pre) Gecko/20090707 Minefield/3.6a1pre I can definitely reproduce this bug using the STR in comment 0. I think this is most likely due to the fact that the window that print preview is loaded from has no toolbar. Since print preview is launched in the window without a toolbar, it has no toolbar as well. Mac is not an issue because it uses the Preview app.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Summary: Print Preview toolbar not shown if window launched without toolbar → [Win][Linux] Print Preview toolbar not shown if launched from window without toolbar
Updated•15 years ago
|
Version: unspecified → 3.0 Branch
Assignee | ||
Comment 3•15 years ago
|
||
I'm not sure if this is the correct class to add to the toolbar as I couldn't find documentation on it but this seems to do the trick.
Assignee: nobody → mnoorenberghe
Status: NEW → ASSIGNED
Attachment #387736 -
Flags: review?(gavin.sharp)
Comment 4•15 years ago
|
||
Comment on attachment 387736 [details] [diff] [review] v.1 add toolbar-primary class to p.p. toolbar Just use .className? Suppose you could change the other to .id too.
Attachment #387736 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 5•15 years ago
|
||
use .className and .id instead of setAttribute
Attachment #387736 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/990d9f7199d7
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
You need to log in
before you can comment on or make changes to this bug.
Description
•