426165 - javascript in template flag/list.html.tmpl overwrites default onload-Event

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Alexander Kraus]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Build Identifier: bugzilla-3.1.3

in line 71 of the file flag/list.html.tmpl the default javascript onload event gets overwritten:
> window.onload = disableRequesteeFields;

in cause of that, all other javascript function calls what may be attached to onload are removed.

here it would be better to write
window.attachEvent("onload",disableRequesteeFields);
to avoid problems with other functions

Reproducible: Always

Comment 1

[Guy Pyrzak]

This is true (I noticed it a while ago), however, right now this isn't effecting anything and the fix is trivial. I would suggest the following: 

YAHOO.util.Event.addListener(window, "load", disableRequesteeFields);

I'll attach a patch. But like i said, it doesn't really effect anything.

Comment 2

[Guy Pyrzak]

Attachment: Flag Patch V1

here is the fix to the bug.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 313364 [details] [diff] [review]
Flag Patch V1

This is fine, if you're absolutely certain that the yahoo JS is loaded everywhere that this template is called.

Comment 4

[Max Kanat-Alexander]

Since this doesn't fix anything, I think it should only go into 4.0, actually.

Comment 5

[Guy Pyrzak]

Yup, I agree. Notice i didn't put a blocker for 3.2. Hopefully by then we'll fix the yahoo js being where it needs to be.

Comment 6

[Guy Pyrzak]

Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.33; previous revision: 1.32
done