Closed Bug 426175 Opened 15 years ago Closed 15 years ago

FUEL Application.extensions isn't working

Categories

(Firefox :: General, defect)

x86
Windows Vista
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Assigned: mfinkle)

Details

(Whiteboard: [has patch][has reviews])

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008033005 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008033005 Minefield/3.0pre

Title says it all. Calling alert(Application.extensions) in the Error console returns null. Should return a fuelIExtensions interface.

Reproducible: Always




Someone on Mozillazine (http://forums.mozillazine.org/viewtopic.php?p=3319634#3319634) proposed it was related to these two checkins:

2008-03-25 14:19 / https://bugzilla.mozilla.org/show_bug.cgi?id=425062
2008-03-24 17:38 / https://bugzilla.mozilla.org/show_bug.cgi?id=407693
It will actually be most likely bug 407963 that caused this. For some reason though it implemented an nsIClassInfo for fuelApplication it fails to include extIApplication in the interface list and that also isn't included in the QI implementation.
and bug 420028 disabled Application.extensions tests
A fair bit of fuel is broken here, this should be fixed for final.
Flags: blocking-firefox3?
Status: UNCONFIRMED → NEW
Ever confirmed: true
This patch fixes the call to the base class so the "this" reference is correct. It also adds extIApplication to the Application QI and getInterfaces methods.

The patch passes the basic extension tests found in bug 420028, which fail without this patch.
Assignee: nobody → mark.finkle
Status: NEW → ASSIGNED
Attachment #312772 - Flags: review?(gavin.sharp)
Attachment #312772 - Flags: review?(gavin.sharp) → review+
Comment on attachment 312772 [details] [diff] [review]
simple fix for calling base class methods

This is really a blocker.
Attachment #312772 - Flags: approval1.9?
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [has patch][has reviews]
Comment on attachment 312772 [details] [diff] [review]
simple fix for calling base class methods

no approval needed, land when ready
Attachment #312772 - Flags: approval1.9?
/cvsroot/mozilla/browser/fuel/src/fuelApplication.js,v  <--  fuelApplication.js
new revision: 1.29; previous revision: 1.28
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.