426175 - FUEL Application.extensions isn't working

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Wesley Johnston (:wesj)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008033005 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008033005 Minefield/3.0pre

Title says it all. Calling alert(Application.extensions) in the Error console returns null. Should return a fuelIExtensions interface.

Reproducible: Always




Someone on Mozillazine (http://forums.mozillazine.org/viewtopic.php?p=3319634#3319634) proposed it was related to these two checkins:

2008-03-25 14:19 / https://bugzilla.mozilla.org/show_bug.cgi?id=425062
2008-03-24 17:38 / https://bugzilla.mozilla.org/show_bug.cgi?id=407693

Comment 1

[Dave Townsend [:mossop]]

It will actually be most likely bug 407963 that caused this. For some reason though it implemented an nsIClassInfo for fuelApplication it fails to include extIApplication in the interface list and that also isn't included in the QI implementation.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

and bug 420028 disabled Application.extensions tests

Comment 3

[Dave Townsend [:mossop]]

A fair bit of fuel is broken here, this should be fixed for final.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: simple fix for calling base class methods

This patch fixes the call to the base class so the "this" reference is correct. It also adds extIApplication to the Application QI and getInterfaces methods.

The patch passes the basic extension tests found in bug 420028, which fail without this patch.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 312772 [details] [diff] [review]
simple fix for calling base class methods

This is really a blocker.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 312772 [details] [diff] [review]
simple fix for calling base class methods

no approval needed, land when ready

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

/cvsroot/mozilla/browser/fuel/src/fuelApplication.js,v  <--  fuelApplication.js
new revision: 1.29; previous revision: 1.28