426317 - Drop nsIAbMDBDirectory::getDirUri

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

nsIAbMDBDirectory::getDirUri is the same as getting the URI from the RDF resource. Its only used in one place which can easily be changed.

I've also changed a function call in nsMsgCompose (as I wanted to remove the comment) to avoid a getter_Copies call.

I want this to help start to clean up our current mess of get URI implementations.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix v2

Improved version removing the rdf api calls.

Comment 2

[[e-mail]]

Comment on attachment 312945 [details] [diff] [review]
The fix v2

I particularly like the nsMsgCompose change :-)

Comment 3

[Mark Banner (:standard8)]

Patch checked in -> fixed.

Comment 4

[Kent James (:rkent)]

While reviewing the address book search setup as part of preparing unit tests for bug 187768, I saw some code I did not understand which I traced to this patch.

Previously, in nsMsgSearchTerm::InitializeAddressBook there was this code:

    if (strcmp(dirURI.get(), m_value.string))
      mDirectory = nsnull; // clear out the directory....we are no longer pointing to the right one


which has now been replaced by:

    if (uri.Equals(m_value.string))
      // clear out the directory....we are no longer pointing to the right one
      mDirectory = nsnull;

But the logic is backwards. strcmp returns 0 (false) when the string are equal. So the new code should be:

    if (!uri.Equals(m_value.string))

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> While reviewing the address book search setup as part of preparing unit tests
> for bug 187768, I saw some code I did not understand which I traced to this
> patch.

As this was code that got released (TB 3.0a1), I've raised a separate bug to handle the fixing of this (bug 436104).