Closed Bug 42634 Opened 20 years ago Closed 17 years ago

nsSliderFrame::GetContentOf hides inherited method

Categories

(Core :: Layout, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: Brade, Assigned: marc.loiselle)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 2 obsolete files)

on the Macintosh tinderbox Warning page, I see these warnings which should be 
investigated:

nsSliderFrame::GetContentOf(nsIBox *, nsIContent **)' hides inherited virtual 
function 'nsBoxFrame::GetContentOf(nsIContent **)
evaughan
Assignee: pinkerton → evaughan
targeting
Status: NEW → ASSIGNED
Target Milestone: --- → M20
moving all evaughan non-nsbeta3+ bugs to Future milestone, per trudelle
Target Milestone: M20 → Future
Blocks: 179028
Just renaming the method would make the warning go away (and make things
clearer, imo).
Whiteboard: [good first bug]
Rename nsSliderFrame::GetContentOf to nsSliderFrame::GetContentOfScrollbar. 
The method is private is only used by nsSliderFrame.cpp.
Attachment #124149 - Flags: superreview?(bryner)
Attachment #124149 - Flags: review?(dbaron)
Comment on attachment 124149 [details] [diff] [review]
Removes "GetContentOf is hidden" warning

I'd prefer "GetContentForBox" since that's what the function does.
Attachment #124149 - Flags: superreview?(bryner) → superreview-
GetContentOfBox() instead of GetContentOf() to fix compiler warning
Attachment #124149 - Attachment is obsolete: true
Attachment #124245 - Flags: superreview?(bryner)
Attachment #124245 - Flags: review?(dbaron)
Attachment #124149 - Flags: review?(dbaron)
Comment on attachment 124245 [details] [diff] [review]
Removes "GetContentOf is hidden" warning v2

I don't see any reason for this to be a (non-static) member function -- it just
means you're passing around an extra |this| pointer that you don't need. 
However, why should it be a member at all?  How about:

static already_AddRefed<nsIContent>
ContentOfBox(nsIBox *aBox)
{
  nsIFrame *frame;
  aBox->GetFrame(&frame);
  nsIContent *content;
  frame->GetContent(&content);
  return content;
}
Add static GetContentOfBox() function.	Remove nsSliderFrame::GetContentOf().
Attachment #124245 - Attachment is obsolete: true
Attachment #124313 - Flags: superreview?(bryner)
Attachment #124313 - Flags: review?(dbaron)
Attachment #124245 - Flags: superreview?(bryner)
Attachment #124245 - Flags: review?(dbaron)
Attachment #124313 - Flags: review?(dbaron) → review+
Attachment #124313 - Flags: superreview?(bryner) → superreview+
dbaron, Can you check-in for me?
.
Assignee: eric → mloiselle
Status: ASSIGNED → NEW
Fix checked in to trunk, 2003-06-01 19:39 -0700.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.