42636 - warnings for unwanted ';' on Macintosh builds

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Kathleen :Brade]

on the Macintosh tinderbox Warning page, I see these warnings which could be 
fixed very easily:

Possible unwanted ';'

      intl/uconv/src/nsCharsetMenu.cpp:933
      intl/uconv/src/nsCharsetMenu.cpp:958

Line 933 could be fixed by simply adding the curly braces like this:
  for (; (*q != ',') && (*q != ' ') && (*q != 0); q++) {;}
or it could be fixed by making it two lines:
  for (; (*q != ',') && (*q != ' ') && (*q != 0); q++)
    ;

Line 958 (for (; (*q == ',') || (*q == ' '); q++);) can be fixed either way.

Either way, the warnings will go away on Macintosh and it will be clearer to 
others looking at the code that you intended to have an empty loop.

Comment 1

[Frank Tang]

cata- I think I mention this to you. I don't think this is nsbeta2 but you 
should use common C++ coding style and avoid this kind of issue. Thanks.

Comment 2

[cata]

Fixed.

Comment 3

[Teruko Kobayashi]

Verified.