Closed Bug 426383 Opened 12 years ago Closed 4 years ago

[10.5] Changes made to toolbar aren't saved until exit

Categories

(Firefox :: Toolbars and Customization, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: marcia, Unassigned)

Details

(Keywords: regression)

Seen using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040104 Minefield/3.0pre.

STR:
1. Customize the toolbar to show Icons and text.
2. Crash the browser. In my case I had 4 crashes in the toolbar so I did not have to use http://ted.mielczarek.org/code/mozilla/crashme.xpi.
3. Restart Firefox

Expected: My toolbar customization would be preserved.
Actual: Toolbar customization is reset to default.

I tested both Tiger and Win XP and this works correctly there.
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040204 Minefield/3.0pre

Confirmed, added buttons, crashed, they were gone.  Added text, exited completely, re-opened, crashed, they're still there.

I believe the bug is "changes to toolbar aren't saved until exit".
Summary: [10.5] Toolbar resets to default after crash → [10.5] Changes made to toolbar aren't saved until exit
We could explicitly flush the new preferences to disk when closing the customize toolbar dialog, but I don't think that we should go through the trouble of doing it for something as trivial as toolbar customizations.
I don't see this issue on the latest nightly build. I tested on 

Name 	Firefox
Version 	48.0a1
Build ID 	20160408030212
User Agent 	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0

Closing this bug as resolved: workforme. Feel free to reopen this if you encounter this issue on the latest released versions.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.