426412 - GDI leak in April 1 build

Status: VERIFIED WORKSFORME

(Firefox :: General, defect)

Description

[Jo Hermans]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040108 Minefield/3.0pre

I just noticed that the nightly build of today has a huge GDI leak on windows. I was used seeing a few hundred GDI objects allocated (thanks to Alfreds work on discarding the images), but I suddenly noticed that Firefox was using over 6000 GDI objects, and it was still climbing. I checked with the build from yesterday (Gecko/2008033105), and that doesn't show this behavior.

In a completely unscientific test, I rapidly loaded 6 bookmarks with several images, and then waited 2 minutes. The GDI count can be seen in Task Manager, but you'll have to add the column first. Yesterdays build used 331 GDI objects, todays used 1014 objects.

At first I thought that Joe Drew was testing for bug 399925, but that wasn't the case. Could this be another regression from bug 382392 (it was already backed out after the crashes in bug 426369) ? I don't think that the 2008040108 build has this already backed out (that happened at 10 AM). I noticed that there were 2 updates today.

Comment 1

[Jo Hermans]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040112 Minefield/3.0pre

It seems that the 3th update from today fixed the issue.

I guess it was another regression of bug 382392, or maybe the second one was made during the backout. Note: I forgot to mention that I first was using the automatic
updated versions, and then I tried with a full download, just to rule out a bad update.