426469 - Reviews for some add-ons cannot be viewed

Status: VERIFIED DUPLICATE of bug 428118

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Kai Liu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13
Build Identifier: 

Even when I am logged in, I cannot read the reviews for a sandboxed item.  The reviews are simply not on the page, and the reviews link on the left underneath the screenshot do nothing.

Reproducible: Always

Steps to Reproduce:
1. Log into AMO.
2. Find and go to a sandboxed extension that has reviews.
3. Try to read a review.
Actual Results:  
There are no reviews on the page.  Clicking on the link underneath the screenshot that says "2 reviews" doesn't do anything, either.

Expected Results:  
Display the reviews.

Comment 1

[Fred Wenzel [:wenzel]]

Confirming. One example for such an add-on is

https://addons.mozilla.org/en-US/firefox/addon/4902

The page reads "1 review" but they are not shown anywhere.

Comment 2

[Basil Hashem [:baz]]

Targeting v3.4, this is a regression.

Comment 3

[Fred Wenzel [:wenzel]]

Note: I looked into this problem a little and it's my impression that an add-on being in the sandbox does not automatically lead to this problem. There are (plenty of?) add-ons in the sandbox whose reviews are displayed fine, such as:

https://addons.mozilla.org/en-US/firefox/addon/3171

The problem may be fixed by the patch for bug 398065 (still in review), but as I haven't found the exact problem yet, I can not claim this confidently yet. Need to re-check in the course of TM 3.4, then the patch mentioned will likely have landed too.

Comment 4

[Basil Hashem [:baz]]

I also saw this with one of my test add-ons, I created a brand new add-on and uploaded it. Made the add-on public (perhaps that's the key?) The details page showed "1 review(s)" but clicking on it yielded nothing. Sandboxed it for ending the test. That's a reproducible test case.

I've since added a single review and here's what you get:
https://addons.mozilla.org/en-US/firefox/search/?q=baz3000 (shows not yet rated, 1 review) - I think is wrong.
https://addons.mozilla.org/en-US/firefox/addon/6926 - shows 2 reviews. Clicking the link does nothing.
https://addons.mozilla.org/en-US/firefox/reviews/display/6926 - is blank

Comment 5

[Kai Liu]

So I guess from comment #3 and comment #4 that the problem isn't the sandboxing... Newly created comments?  Or newly created comments added to a page that previously had no comments?

Comment 6

[Kai Liu]

Here's another case:
https://addons.mozilla.org/6639

As of the time of this comment, AMO says that there are 5 reviews for the addon.  Of those 5, one of them is accessible.  So I wonder, could this be a problem with comments being delayed?  If so, this delay seems to be fairly severe.  I received a comment on a new extension of mine, 6912, a number of days ago, and I still couldn't read it as of the time of this comment, which is a little bit frustrating because I am cut off from that particular avenue of feedback.

Comment 7

[Fred Wenzel [:wenzel]]

Investigating this more closely, this seems to be the same issue as bug 428118, which is targeted to be fixed ASAP, so duping against that bug. Thanks.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Kai - this should be fixed, now; please let us know if it's not, thanks!