Closed
Bug 426563
Opened 16 years ago
Closed 16 years ago
arm xptc stubs need to explicitly place symbols in text section
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
Details
(Whiteboard: [blocking-mobile?])
Attachments
(1 file)
|
956 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Using GCC 4.2, the assembly generated from the arm xptc stubs doesn't necessarily have any code emitted before the SharedStub symbol, causing it to end up in the wrong section -- often the debug section, which doesn't get mapped and so causes a segfault. The attached patch fixes this, but just placing a section directive before the symbol.
Attachment #313127 -
Flags: review?(shaver)
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [blocking-mobile?]
|
|
Assignee | |
Comment 1•16 years ago
|
||
Comment on attachment 313127 [details] [diff] [review] put SharedStub symbol in text section Switching review over to bsmedberg; this should be an easy safe fix for a runtime issue. (This manifests itself as a crash on startup, when the first xpcom method is called from JS.)
Attachment #313127 -
Flags: review?(shaver) → review?(benjamin)
|
||
Updated•16 years ago
|
Attachment #313127 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•