If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Provide a standard Directory Provider service for mailnews xpcshell tests

RESOLVED FIXED in Thunderbird 3.0a3

Status

MailNews Core
Backend
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.0a3
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 313190 [details] [diff] [review]
The fix

We've currently got two implementations of the directory provider service providing profile locations on trunk for xpcshell tests. Bug 413077 wants one, and various other places do.

We should therefore have a common file that we can obtain the provider service from. Ideally I'd like to have a clean-up file as well, but I think I'll leave that to a different bug.

Dan mentioned on irc that we should be able to install this as a "global" head/tail script - I'll file a bug on that tomorrow when I'm a little more awake.
Attachment #313190 - Flags: superreview?(dmose)
Attachment #313190 - Flags: review?(dmose)
(Assignee)

Comment 1

10 years ago
Created attachment 315944 [details] [diff] [review]
The fix v2

Corrected version -> mailList1.js now passes (I don't know how I missed that in the first version), also explicitly details where the test directory with the files in will be.
Attachment #313190 - Attachment is obsolete: true
Attachment #315944 - Flags: superreview?(dmose)
Attachment #315944 - Flags: review?(dmose)
Attachment #313190 - Flags: superreview?(dmose)
Attachment #313190 - Flags: review?(dmose)

Comment 2

10 years ago
Comment on attachment 315944 [details] [diff] [review]
The fix v2

Looks good; r+sr=dmose.
Attachment #315944 - Flags: superreview?(dmose)
Attachment #315944 - Flags: superreview+
Attachment #315944 - Flags: review?(dmose)
Attachment #315944 - Flags: review+
(Assignee)

Comment 3

10 years ago
Patch checked in -> fixed.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
Depends on: 462955
Depends on: 438922
No longer depends on: 462955
Target Milestone: --- → Thunderbird 3.0b3
(Assignee)

Comment 4

8 years ago
This was checked in pre alpha-1 so setting a b3 target doesn't make sense. Setting a3 as we've already passed that and we don't have an a1 target.
Target Milestone: Thunderbird 3.0b3 → Thunderbird 3.0a3
You need to log in before you can comment on or make changes to this bug.