To better test for GC regressions on the branch we need to land the dynamic gczeal changes. To avoid muddying long-fixed trunk bugs this bug will track that landing and should hold the final merged branch patch, including fixes for the regressions found.
We do want this one for the 188.8.131.52 releases, it's just too hard to verify and test for GC bugs otherwise and the kinks seem to be worked out on the trunk now.
Created attachment 317741 [details] [diff] [review] patch donated by MikeM This is a patch MikeM kindly rolled up; I still need to review it.
Comment on attachment 317741 [details] [diff] [review] patch donated by MikeM crowder: ping?
dveditz: I have another rev of this patch that I'm building/testing now.... will post the patch shortly.
Created attachment 322857 [details] [diff] [review] new rev Spun by hand from the trunk patches
Old patches gcPadding change is wrong, but these otherwise match up well, I think.
Comment on attachment 322857 [details] [diff] [review] new rev Woops, need a quick fix for something here, before review.
Created attachment 322957 [details] [diff] [review] tested and fixed This one works better.
Comment on attachment 322957 [details] [diff] [review] tested and fixed Should be good to go for 1.8
Comment on attachment 322957 [details] [diff] [review] tested and fixed Just checking before we approve this, does this include all the regression fixes? (we're assuming that's what "rollup" meant in an earlier comment)
It includes all the patches from the bugs on which this bug depends. If there are others you or I have overlooked, then we'll be missing those. I'm fairly certain this is everything, and gczeal definitely works in the 1.8 browser I've built with this (it is, in other words, appallingly slow).
Comment on attachment 322957 [details] [diff] [review] tested and fixed Thanks. Approved for 184.108.40.206, a=dveditz for release-drivers
Checking in dom/src/base/nsJSEnvironment.cpp; /cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v <-- nsJSEnvironment.cpp new revision: 1.262.2.14; previous revision: 1.262.2.13 done Checking in js/src/js.c; /cvsroot/mozilla/js/src/js.c,v <-- js.c new revision: 220.127.116.11; previous revision: 18.104.22.168 done Checking in js/src/jsapi.c; /cvsroot/mozilla/js/src/jsapi.c,v <-- jsapi.c new revision: 22.214.171.124; previous revision: 126.96.36.199 done Checking in js/src/jsapi.h; /cvsroot/mozilla/js/src/jsapi.h,v <-- jsapi.h new revision: 188.8.131.52; previous revision: 184.108.40.206 done Checking in js/src/jscntxt.h; /cvsroot/mozilla/js/src/jscntxt.h,v <-- jscntxt.h new revision: 220.127.116.11; previous revision: 18.104.22.168 done Checking in js/src/jsgc.c; /cvsroot/mozilla/js/src/jsgc.c,v <-- jsgc.c new revision: 22.214.171.124; previous revision: 126.96.36.199 done Checking in js/src/jsgc.h; /cvsroot/mozilla/js/src/jsgc.h,v <-- jsgc.h new revision: 188.8.131.52; previous revision: 184.108.40.206 done Checking in js/src/jsobj.c; /cvsroot/mozilla/js/src/jsobj.c,v <-- jsobj.c new revision: 220.127.116.11; previous revision: 18.104.22.168 done
Branch only bug. Marking as FIXED.
This needed a followup build-fix (for release): Checking in nsJSEnvironment.cpp; /cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v <-- nsJSEnvironment.cpp new revision: 1.262.2.15; previous revision: 1.262.2.14 done
gczeal exists in the shell and browser, but the shell is missing the command line option to set the zeal. crowder, can we have a followup patch after 22.214.171.124 for the command line option Z?