Land dynamic gczeal on 1.8 branch

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dveditz, Assigned: Brian Crowder)

Tracking

({meta, verified1.8.1.15})

Trunk
meta, verified1.8.1.15
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1.15 +
wanted1.8.1.x +
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

9 years ago
To better test for GC regressions on the branch we need to land the dynamic gczeal changes. To avoid muddying long-fixed trunk bugs this bug will track that landing and should hold the final merged branch patch, including fixes for the regressions found.
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.15?
(Reporter)

Comment 1

9 years ago
We do want this one for the 1.8.1.15 releases, it's just too hard to verify and test for GC bugs otherwise and the kinks seem to be worked out on the trunk now.
Flags: blocking1.8.1.15? → blocking1.8.1.15+
(Assignee)

Comment 2

9 years ago
Created attachment 317741 [details] [diff] [review]
patch donated by MikeM

This is a patch MikeM kindly rolled up; I still need to review it.
Attachment #317741 - Flags: review?
(Reporter)

Comment 3

9 years ago
Comment on attachment 317741 [details] [diff] [review]
patch donated by MikeM

crowder: ping?
Attachment #317741 - Flags: review? → review?(crowder)
(Assignee)

Comment 4

9 years ago
dveditz:  I have another rev of this patch that I'm building/testing now....  will post the patch shortly.
(Assignee)

Comment 5

9 years ago
Created attachment 322857 [details] [diff] [review]
new rev

Spun by hand from the trunk patches
Attachment #317741 - Attachment is obsolete: true
Attachment #317741 - Flags: review?(crowder)
(Assignee)

Comment 6

9 years ago
Old patches gcPadding change is wrong, but these otherwise match up well, I think.
(Assignee)

Updated

9 years ago
Attachment #322857 - Flags: review?(igor)
(Assignee)

Comment 7

9 years ago
Comment on attachment 322857 [details] [diff] [review]
new rev

Woops, need a quick fix for something here, before review.
Attachment #322857 - Flags: review?(igor)
(Assignee)

Comment 8

9 years ago
Created attachment 322957 [details] [diff] [review]
tested and fixed

This one works better.
Attachment #322857 - Attachment is obsolete: true
Attachment #322957 - Flags: review?(igor)

Updated

9 years ago
Attachment #322957 - Flags: review?(igor) → review+
(Assignee)

Comment 9

9 years ago
Comment on attachment 322957 [details] [diff] [review]
tested and fixed

Should be good to go for 1.8
Attachment #322957 - Flags: approval1.8.1.15?
(Reporter)

Comment 10

9 years ago
Comment on attachment 322957 [details] [diff] [review]
tested and fixed

Just checking before we approve this, does this include all the regression fixes? (we're assuming that's what "rollup" meant in an earlier comment)
(Assignee)

Comment 11

9 years ago
It includes all the patches from the bugs on which this bug depends.  If there are others you or I have overlooked, then we'll be missing those.  I'm fairly certain this is everything, and gczeal definitely works in the 1.8 browser I've built with this (it is, in other words, appallingly slow).
(Reporter)

Comment 12

9 years ago
Comment on attachment 322957 [details] [diff] [review]
tested and fixed

Thanks.

Approved for 1.8.1.15, a=dveditz for release-drivers
Attachment #322957 - Flags: approval1.8.1.15? → approval1.8.1.15+
(Assignee)

Updated

9 years ago
Depends on: 427185
(Assignee)

Comment 13

9 years ago
Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.262.2.14; previous revision: 1.262.2.13
done
Checking in js/src/js.c;
/cvsroot/mozilla/js/src/js.c,v  <--  js.c
new revision: 3.93.2.17; previous revision: 3.93.2.16
done
Checking in js/src/jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.214.2.43; previous revision: 3.214.2.42
done
Checking in js/src/jsapi.h;
/cvsroot/mozilla/js/src/jsapi.h,v  <--  jsapi.h
new revision: 3.107.2.12; previous revision: 3.107.2.11
done
Checking in js/src/jscntxt.h;
/cvsroot/mozilla/js/src/jscntxt.h,v  <--  jscntxt.h
new revision: 3.80.4.26; previous revision: 3.80.4.25
done
Checking in js/src/jsgc.c;
/cvsroot/mozilla/js/src/jsgc.c,v  <--  jsgc.c
new revision: 3.104.2.36; previous revision: 3.104.2.35
done
Checking in js/src/jsgc.h;
/cvsroot/mozilla/js/src/jsgc.h,v  <--  jsgc.h
new revision: 3.33.4.13; previous revision: 3.33.4.12
done
Checking in js/src/jsobj.c;
/cvsroot/mozilla/js/src/jsobj.c,v  <--  jsobj.c
new revision: 3.208.2.59; previous revision: 3.208.2.58
done
Keywords: fixed1.8.1.15
Branch only bug. Marking as FIXED.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 15

9 years ago
This needed a followup build-fix (for release):
Checking in nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.262.2.15; previous revision: 1.262.2.14
done

Comment 16

9 years ago
gczeal exists in the shell and browser, but the shell is missing the command line option to set the zeal. crowder, can we have a followup patch after 1.8.1.15 for the command line option Z?
Keywords: fixed1.8.1.15 → verified1.8.1.15

Updated

9 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.