Closed Bug 426771 Opened 14 years ago Closed 14 years ago

Export cross tool variables in universal mozconfig

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9

People

(Reporter: benjamin, Assigned: benjamin)

Details

Attachments

(1 file)

The universal mozconfig sets CC/CXX/etc locally, but doesn't export them into the environment. This happens to work with NSPR because it uses a shared config.cache. But it won't work with Tamarin which doesn't use autoconf (this is causing build bustage in Actionmonkey). I think we should, for sanity, export all the relevant variables, which also reduces our reliance on the shared config.cache for NSPR.

I'd like to take this for 1.9 unless you see a reason not to.
Attachment #313342 - Flags: review?(ted.mielczarek)
Comment on attachment 313342 [details] [diff] [review]
export universal mozconfig vars, rev. 1

I don't have a problem with this unless Mark has some reason not to.
Attachment #313342 - Flags: review?(ted.mielczarek) → review+
Attachment #313342 - Flags: approval1.9?
I pushed this to actionmonkey to solve the bustage there, in the meantime.
Comment on attachment 313342 [details] [diff] [review]
export universal mozconfig vars, rev. 1

a1.9=beltzner
Attachment #313342 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in build/macosx/universal/mozconfig;
/cvsroot/mozilla/build/macosx/universal/mozconfig,v  <--  mozconfig
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
FWIW, the patch here was incorrect. In shell you have to separate variables to export with spaces, not with commas. I have committed the correct fix to CVS and actionmonkey.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.