Export cross tool variables in universal mozconfig

RESOLVED FIXED in mozilla1.9

Status

()

Core
Build Config
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Trunk
mozilla1.9
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 313342 [details] [diff] [review]
export universal mozconfig vars, rev. 1

The universal mozconfig sets CC/CXX/etc locally, but doesn't export them into the environment. This happens to work with NSPR because it uses a shared config.cache. But it won't work with Tamarin which doesn't use autoconf (this is causing build bustage in Actionmonkey). I think we should, for sanity, export all the relevant variables, which also reduces our reliance on the shared config.cache for NSPR.

I'd like to take this for 1.9 unless you see a reason not to.
Attachment #313342 - Flags: review?(ted.mielczarek)
Comment on attachment 313342 [details] [diff] [review]
export universal mozconfig vars, rev. 1

I don't have a problem with this unless Mark has some reason not to.
Attachment #313342 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

10 years ago
Attachment #313342 - Flags: approval1.9?
(Assignee)

Comment 2

10 years ago
I pushed this to actionmonkey to solve the bustage there, in the meantime.
Comment on attachment 313342 [details] [diff] [review]
export universal mozconfig vars, rev. 1

a1.9=beltzner
Attachment #313342 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in build/macosx/universal/mozconfig;
/cvsroot/mozilla/build/macosx/universal/mozconfig,v  <--  mozconfig
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
(Assignee)

Comment 5

10 years ago
FWIW, the patch here was incorrect. In shell you have to separate variables to export with spaces, not with commas. I have committed the correct fix to CVS and actionmonkey.
You need to log in before you can comment on or make changes to this bug.