426771 - Export cross tool variables in universal mozconfig

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Attachment: export universal mozconfig vars, rev. 1

The universal mozconfig sets CC/CXX/etc locally, but doesn't export them into the environment. This happens to work with NSPR because it uses a shared config.cache. But it won't work with Tamarin which doesn't use autoconf (this is causing build bustage in Actionmonkey). I think we should, for sanity, export all the relevant variables, which also reduces our reliance on the shared config.cache for NSPR.

I'd like to take this for 1.9 unless you see a reason not to.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 313342 [details] [diff] [review]
export universal mozconfig vars, rev. 1

I don't have a problem with this unless Mark has some reason not to.

Comment 2

[Benjamin Smedberg]

I pushed this to actionmonkey to solve the bustage there, in the meantime.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 313342 [details] [diff] [review]
export universal mozconfig vars, rev. 1

a1.9=beltzner

Comment 4

[Reed Loden [:reed]]

Checking in build/macosx/universal/mozconfig;
/cvsroot/mozilla/build/macosx/universal/mozconfig,v  <--  mozconfig
new revision: 1.6; previous revision: 1.5
done

Comment 5

[Benjamin Smedberg]

FWIW, the patch here was incorrect. In shell you have to separate variables to export with spaces, not with commas. I have committed the correct fix to CVS and actionmonkey.