Closed Bug 426917 Opened 12 years ago Closed 11 years ago

Add padding to Downloads window item list

Categories

(Toolkit :: Themes, enhancement)

x86
Windows XP
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: adelfino, Assigned: dao)

Details

(Keywords: polish)

Attachments

(3 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040311 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040311 Minefield/3.0pre

Add padding to Downloads window item list, it looks quite odd in Windows XP to see "empty background" (white, generally) reach the titlebar.

Don't know how this feels in Windows Vista.

Please compare screenshot and mock-up. Note that I surely didn't use the proper padding, but you get the idea.

Reproducible: Always
Component: Download Manager → Theme
Version: unspecified → Trunk
QA Contact: download.manager → theme
If we make this change we should only do it for non-default windows themes to pick up the style in classic mode.
(In reply to comment #3)
> If we make this change we should only do it for non-default windows themes to
> pick up the style in classic mode.
> 

Sorry, didn't get your comment :S

Didn't try Windows Vista, but Windows XP Luna theme doesn't show something like this in any window.

So I guess this should only be ignored in Windows Vista, since I guess it does use this kind of windows.
I confirm this happens, and only in non-default windows themes.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
Attached patch patchSplinter Review
Assignee: nobody → dao
Attachment #381286 - Flags: review?
Attachment #381286 - Flags: review? → review?(sdwilsh)
Attachment #381286 - Flags: review?(sdwilsh) → review?(rflint)
Attachment #381286 - Flags: review?(rflint) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/d7c4881a4f81
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.