426917 - Add padding to Downloads window item list

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040311 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040311 Minefield/3.0pre

Add padding to Downloads window item list, it looks quite odd in Windows XP to see "empty background" (white, generally) reach the titlebar.

Don't know how this feels in Windows Vista.

Please compare screenshot and mock-up. Note that I surely didn't use the proper padding, but you get the idea.

Reproducible: Always

Comment 1

[Andrés Delfino]

Attachment: Downloads window screenshot.

Comment 2

[Andrés Delfino]

Attachment: Downloads window with padding mock-up.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

If we make this change we should only do it for non-default windows themes to pick up the style in classic mode.

Comment 4

[Andrés Delfino]

(In reply to comment #3)
> If we make this change we should only do it for non-default windows themes to
> pick up the style in classic mode.
> 

Sorry, didn't get your comment :S

Didn't try Windows Vista, but Windows XP Luna theme doesn't show something like this in any window.

So I guess this should only be ignored in Windows Vista, since I guess it does use this kind of windows.

Comment 5

[Lucas Malor (mail: c6kfnkn2uc AT snkmail DOT c0m)]

I confirm this happens, and only in non-default windows themes.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d7c4881a4f81