426933 - Border not drawn with very large padding and negative margin

Status: RESOLVED FIXED

(Core :: Graphics, defect, P2)

Description

[Brian Polidoro]

Attachment: testcase

The borders in this testcase do not draw.  

0318 ok
0319 broken

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-03-18+04%3A00%3A00&maxdate=2008-03-19+06%3A00%3A00&cvsroot=%2Fcvsroot

If the padding and margin are lowered to around 16,000 then the borders are drawn.

Sometimes if I put another window over where the borders should be and then move the window away part of the border is drawn.  So I guess it's a gfx bug.

Comment 1

[Damon Sicore (:damons)]

Maybe a regression from bug 422661 ?    +'ing.  Vlad, thoughts?  

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The problem here is that while cairo itself no longer has a 16-bit coordinate limitation, pixman still does; if we ever need to render anything in software, or transform regions, we'll hit it.  At this point I think we should fix this in 1.9.0.x with a cairo/pixman update; there's already work ongoing to do 24.8 fixed point inside pixman, but it won't be done in time for 1.9.0.0.

Though we can back out the fix for 422661, and get a different set of brokenness.. not sure what the right thing is to do here.  Cc'ing roc -- maybe we should use the correct coordinates on mac only, where pixman isn't involved, and keep it at 16-bit on linux and win32 for now?

Comment 3

[Damon Sicore (:damons)]

Moving to 1.9.0.x per vlad's recommendation.  Roc, if you disagree, please revert.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I agree, good decision.

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: testcase 2

Here's the reduced testcase from bug 434539.

Comment 7

[Daniel Holbert [:dholbert]]

FWIW, on the original testcase (attachment 313517 [details]), I see the outermost border on the main div (wrapping all of the content), but no borders between colored blocks.

I'm running:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008051202 Firefox/3.0

Comment 8

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> Sometimes if I put another window over where the borders should be and then
> move the window away part of the border is drawn.

I see this as well, on both testcases.

Comment 9

[Brian Polidoro]

As stated in Bug 434539 this problem affects the One True Layout hack for faking 100% height.  So this could show up on a number of web sites if they use borders.
http://www.positioniseverything.net/articles/onetruelayout/equalheight

Comment 10

[Brian Polidoro]

I noticed this bug is fixed.  I went back and found this was fixed starting with the 07-23 nightly.  So I assume this was fixed by bug 446323.  Are cairo updates allowed for 1.9.0.x? If not I guess the wanted1.9.0.x+ can be removed.

Comment 11

[Samuel Sidler (old account; do not CC)]

This isn't actually wanted for a maintenance release.