426953 - Remove installTrigger logic from version history page, and change button text from "Add to [platform]" to "Download Now [platform]"

Status: RESOLVED DUPLICATE of bug 433009

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Remove installTrigger logic from version history page, and change button text from "Install" to "Download"

Over in bug 425326 comment 8, Fred writes that it "may make sense to avoid installation on the version history page altogether and just make everything download there, in order to make this the central fallback repository for incompatible/old and similar add-on versions."

Steps to Reproduce:

1. Load a version history page such as https://preview.addons.mozilla.org/en-US/firefox/addons/versions/5202
2. Click on the "Add to Firefox [platform]" links

Actual Results:

We get the installTrigger stuff (sheet/dialog with "Cancel", "Install" buttons)

Expected Results:

If we fix this, we'd just say "Download Now [platform]" and probably change its MIME type or content-disposition (not sure what we do, just a guess).

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

http://morgamic.khan.mozilla.org/amo-reskin/site/en-US/firefox/addons/versions/6617

Visiting that page with a Minefield build on Mac OS X, I see:

"Add to Firefox (Windows)" buttons; different bug?

http://img208.imageshack.us/my.php?image=picture5ib3.png

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #1)

Nevermind me :-)

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

This missed 3.2, but Marcia points out that it's confusing for end-users -- any chance this can make 3.4?

Comment 4

[Tony Chung [:tchung]]

morgamic, Basil, We'd like to get some traction on this prior to the final Fx3 shipping.  Is this possible to get a server-side fix in time?

Comment 5

[Marcia Knous [:marcia]]

It is very confusing, especially for themes. When I am running my tests, I can't tell you the number of times I look for the green button thinking it is compatible, select it, only to find out the theme doesn't work.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Baz/Morgamic: need to know if you think this is severe enough to delay shipping Firefox 3.0

From a UE perspective I think it's bad, but probably not a blocking issue. Would like your opinions, though.

Comment 7

[Basil Hashem [:baz]]

We spoke about this with the team on Friday and we conclude that it's really not that bad an issue (if an issue at all). Perhaps Marcia can clarify why it's so confusing...

E.g. Let's say you visit the versions page for Adblock Plus (https://addons.mozilla.org/en-US/firefox/addons/versions/1865) using Minefield or Firefox 2.0 or Firefox 3.0RC1 - you'll note a huge block at the top that shows you the most recent compatible version. And below that section are listed all the older versions of the add-on. You can click any of the buttons and it will run an installTrigger. Or you can right click and download the add-on, if that's what you are looking to do.

For add-ons that say have multiple versions (one per platform), e.g. eBay companion - https://addons.mozilla.org/en-US/firefox/addons/versions/5202. It still seems pretty clear to me.

In general, end users should be satisfied with the main details page for an add-on. The Versions page is meant for others who wish to download a specific or older version.

Marcia bring up that it's confusing for themes, yet I don't see it - e.g. https://addons.mozilla.org/en-US/firefox/addons/versions/6070 has editions that are compatible with Fx 2 and Fx 3. And it seems pretty clear.

Changing "Add to Firefox" to "Download Now" on this page will require users who want to install directly an older version to download, save to desktop, locate and drag back into Firefox or open it. What a pain. Instead, they simply click.

Those users wishing to download (which is an advanced function to begin with) can simply right click and save it where they want.

I'm going to close this bug as WONTFIX... I am totally missing something here, please re-open.

Thanks.

Comment 8

[Marcia Knous [:marcia]]

Basil: Here is what I think it is confusing:

1. I visit https://addons.mozilla.org/en-US/firefox/browse/type:2
2. I get excited when I see the Foxdie Safari add on with a green button - https://addons.mozilla.org/en-US/firefox/downloads/file/29569/foxdie_safari__blue_-1.1.7-fx.jar
3. I click on it since I assume since the button is green that it is compatible.
4. I go all the way through the install process to find out it is not compatible.

Tomcat has seen this throughout his testing as well. All this will do is aggravate the end user. To me "Green" means good to go and "grey" means stay away since it won't work with my version of Firefox. 

Comment 9

[Tony Chung [:tchung]]

this can't be a wontfix bug.  users are deceived when they see the green add to firefox button on AMO, then click to install it, only to find a popup message saying its not compatible in addons manager.  reopening bug.   We can provide screenshots if you like, but its easy to reproduce.
 

Comment 10

[Basil Hashem [:baz]]

OK, now that we have a better description of what's going on. It's with the "Recommended landing page" for themes - we have already filed bug 433009 to take care of this and will get pushed out this Thursday evening. So, I'm going to mark this as a dup.