426954 - "XPConnect is being called on a scope without a 'Components' property!" assertion message is ridiculously long

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jesse Ruderman]

Attachment: Patch moving the "This is pretty much always bad" paragraph to a comment

The "XPConnect is being called on a scope without a 'Components' property!" assertion message is way too long.  When someone hits the assertion (which happens fairly often), it takes up a large portion of the terminal window, masking other messages they might be more interested in.  I think the paragraph in the assertion message should become a comment.


###!!! ASSERTION: XPConnect is being called on a scope without a 'Components' property!

This is pretty much always bad. It usually means that native code is
making a callback to an interface implemented in JavaScript, but the
document where the JS object was created has already been cleared and the
global properties of that document's window are *gone*. Generally this
indicates a problem that should be addressed in the design and use of the
callback code.
: 'Error', file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/js/src/xpconnect/src/xpcwrappednativescope.cpp, line 770

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 313540 [details] [diff] [review]
Patch moving the "This is pretty much always bad" paragraph to a comment

I think this is fine, but please keep the I_FOOLISHLY_WANT_... ifdef for other XPConnect users.

Comment 2

[Jesse Ruderman]

Fixed, leaving the ifdef.