426964 - add new Indic langGroups to Camino's prefs

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bug 378105 added langGroups for Oriya, Kannada, Sinhala, and Telugu, so we need to add them to prefs, too.  (Default fonts for Kannada and Telugu coming soon in bug 426957.)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Patch

To verify this patch works, you should see Oriya, Telugu, Kannada, and Sinhala in the pop-up of langGroups in the Appearance pane's Font tab.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We now have this increasingly-long list of languages in increasingly-random order,  and I'm wondering if now might not be the time to (re-)region-group, roughly and broadly from west to east:

(Western and European)

Western
Central European
Baltic
Cyrillic
Greek
Unified Canadian Syllabary

(Middle Eastern and African)

Turkish
Hebrew
Arabic
Armenian
Georgian
Ethiopic

(South and Southeast Asian)

Devanagari
Tamil
Bengali
Gujarati
Gurmukhi
Malayalam
Oriya
Telugu
Kannada
Sinhala
Thai
Khmer

(East Asian)

Korean
Traditional Chinese (Taiwan)
Traditional Chinese (Hong Kong)
Simplified Chinese
Japanese

(Other)

Unicode
User-Defined

It would still be a single, undivided list, but instead of the "random" order of today (roughly west to east in the original languages, the others in the order they were added, UCAS, and the original Unicode and user-defined), it'd be west to east (except UCAS, which otherwise would be first), Unicode, user-defined.  Better ordered, I think.

The problem is that we want, in an English Camino, Western always to be first (and/or the default selection), which breaks any sort of otherwise sane-and-equitable ordering.  The other option would be do strict geographical and have some code get your Camino locale and make the pop-up show the "most appropriate" langGroup (though we'd have to do yet more mapping, now of locales to langGroups)....

Comment 3

[Jeff Dlouhy]

Comment on attachment 313770 [details] [diff] [review]
Patch

Does what is expected.

r=jeff

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart, do you have an opinion on comment 2?  

Can we perhaps add some code to make that pop-up behave like the "Add bookmark folder" pop-up, and then we could alphabetize the langGroups list (at least in English).

Comment 5

[Stuart Morgan]

I'm fine with re-ordering, but do we want to consider using submenus? The list is getting awfully long.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

How would you use a sub-menu in a pop-up menu?

Comment 7

[Stuart Morgan]

Sorry, somehow I was convinced we were talking about the text encoding menu.

That ordering seems fine, but if we do want real grouping we could do a <select> group style menu (with disabled items for labels).

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: v2, with regional ordering and a comment

This does the geographic re-ordering described in comment 2 (with some fixes within the regions, since that list was a very quick c/p job that just focused on defining the regions) plus a comment in the .strings file.  (AppleGlot seems OK with the multi-line comment.)

I filed bug 430316 on adding the region 'names' and making "Western" always selected/moving Canadian Syllabics to the proper place geographically.

Comment 9

[philippe (part-time)]

With regional ordering, Korean should be in between Japanese and Chinese.
From West to East
* Chinese (x3)
* Korean
* Japanese

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Oops.  I don't know what I was thinking there :(

Comment 11

[Stuart Morgan]

Comment on attachment 317066 [details] [diff] [review]
v2, with regional ordering and a comment

sr=smorgan (with comment 9 addressed)

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the trunk, with less boneheadedness.