426983 - Make the download option Clear List always available

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Chris Taylor]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5

If don't right click on a file but on an empty row in the download list, the option "Clear List" isn't showed.

Reproducible: Always

Steps to Reproduce:
1. Tools -> Downloads
2. Right click on empty space
3.

Comment 1

[Jesse Ruderman]

Works fine for me on Mac.  Maybe this bug is Windows-specific?

Comment 2

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040402 Minefield/3.0pre

WFM

Comment 3

[Dennis Lichtenthäler]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9pre) Gecko/2008040204 Minefield/3.0pre

I can confirm this bug although it's a little tricky to reproduce.

1. Start a download and wait until it's finished.
2. Start a long-running download
3. Click the still running download
4. Right click empty space in the download manager

Result: No "Clear List" menu option

Comment 4

[Chris Taylor]

If you right click an ongoing download the option is gone. 

Comment 5

[Dennis Lichtenthäler]

The same thing happens with paused downloads... The context menu items defined in download.js seem to be in effect even when you right click the clear area below the downloads and not an individual entry. Then the entry's context menu is shown.

Comment 6

[Ed Lee :Mardak]

Madhava: Would it be okay to put "Clear List" on all context menus -- even for active downloads?

Comment 7

[Ed Lee :Mardak]

Attachment: v1

Add clear list for active downloads.. those that are downloading, paused, queued, scanning.

Waiting for madhava to comment.

Comment 8

[Ed Lee :Mardak]

Comment on attachment 315167 [details] [diff] [review]
v1

<madhava>	Mardak - yeah, let's do it

Comment 9

[Shawn Wilsher :sdwilsh]

Comment on attachment 315167 [details] [diff] [review]
v1

r=sdwilsh

you might need to make some tests for this to land fyi.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 315167 [details] [diff] [review]
v1

a=beltzner

Comment 11

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.146; previous revision: 1.145
done

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041306 Minefield/3.0pre and the Mac nightly on 10.5 (whose build ID I'm too lazy to paste here!)

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+

https://litmus.mozilla.org/show_test.cgi?id=5256

Comment 14

[Ed Lee :Mardak]

Whee.. bug 400495 will remove clear list from all the menus ;)