426989 - Long sidebar on details page continues below footer

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Fred Wenzel [:wenzel]]

Attachment: Add-ons list vs. footer

Add-ons where the author has a lot of other add-ons can result in the right sidebar continuing *below* the page footer. That looks quite odd.

Expected behavior: The sidebar should push the footer as low as it needs to go in order not to conflict with the sidebar content.

Comment 1

[Craig Cook (:craigcook)]

The sidebar is positioned with CSS and taken out of the natural document flow, so the footer (and indeed the rest of the page) doesn't make any accommodations for its size.

I can rework the layout so it uses floated elements rather than positioning,  since floats do affect the layout of adjacent elements and can push the footer down as needed. Hopefully the fix won't require any changes to the markup, just the style sheet.

Comment 2

[Wil Clouser [:clouserw]]

What's the status on this?  Do you need any help?

Comment 3

[Craig Cook (:craigcook)]

Unfortunately floated layouts dictate the source order of elements, so it doesn't seem like this is an easy fix. It'll require a more significant rebuild of the structural markup, which is probably beyond the scope of this release. Sorry about that.

My interim suggestion would be to show a truncated list of the author's addons in the sidebar (which is how I interpreted the mockup when I was building the page). So maybe if the list is limited to a maximum of 5 or 10 (not sure how the 5 or 10 should be chosen... alphabetical, by popularity, random?) followed by a "more..." link that'll solve all our problems.

Comment 4

[Michael Morgan [:morgamic]]

17:00 <@morgamic> could put everything in a auto-submit select list

Comment 5

[Fred Wenzel [:wenzel]]

(In reply to comment #4)
> 17:00 <@morgamic> could put everything in a auto-submit select list

I like the idea. How about if there are <= 3 add-ons in the list, we make a regular list, otherwise a dropdown.

Comment 6

[Michael Morgan [:morgamic]]

Sounds good to me.  Objections?

Comment 7

[Wil Clouser [:clouserw]]

Attachment: add select list

This feels really hackish to me.  I'd much rather fix the layout so it expands as necessary.

Comment 8

[Michael Morgan [:morgamic]]

Comment on attachment 320258 [details] [diff] [review]
add select list

select is off-center, but this'll work in the short term until we make larger template adjustments.  thanks for adding the submit button.

Comment 9

[Wil Clouser [:clouserw]]

fix is in r13063

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; https://preview.addons.mozilla.org/en-US/firefox/addon/1932 is a good testcase.  I also tested with JavaScript disabled, and it worked just fine (comment 8).

Also tested that https://preview.addons.mozilla.org/en-US/firefox/addon/5207 (with only three add-ons, and thus, doesn't meet the condition to populate as a <select> correctly displays/works.