Closed Bug 427033 Opened 14 years ago Closed 14 years ago
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5 If I enter my username and password for the first time, the Password Manager-bar does come up, but the "Remember Password" button doesn't work; nothing happens when you click it. The other buttons, "Not now" and "Never for this website" do work, and do make the bar disappear. The password really isn't saved, it's not in the password manager menu, and when I remove my cookies, I'm logged out of the website and it doesn't prompt my username when I start typing it in the Login-field. Reproducible: Always Steps to Reproduce: 1. Go to http://www.spele.nl/ 2. Create an account 3. Log in to your account, and try to save the password. Actual Results: Nothing, the "Remember Password" button doesn't seem to do anyting at all. Expected Results: The bar should have disappeared, and my username and password should have been remembered the next time I visited this site.
Has this worked at one time (like in another beta) and recently stopped working?
Version: unspecified → Trunk
Can you attach some logs of what's happening? See: http://wiki.mozilla.org/Firefox:Password_Manager_Debugging
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
(In reply to comment #1) > Has this worked at one time (like in another beta) and recently stopped > working? This shouldn't have worked since the new password manager landed a year ago [so I think this isn't blocking-ff3, but I'd like to fix it for FF 3.0.1]. Not sure what FF2 did -- could you test? It would be good to know what it saves, and see if we migrate old logins correctly.
[Oops, I didn't notice HTML didn't work either... :-) ] Anyway, I just tested it in Firefox 220.127.116.11, and it DOES work there, no problems at all.
Assignee: nobody → dolske
Status: NEW → ASSIGNED
Attachment #314241 - Flags: review?(gavin.sharp)
Renomming for blocking, since this is a regression. It wasn't supposed to work before, but people might be using it. Patch is simple and safe, and has -- omgomg -- tests.
Flags: wanted1.9.0.x? → blocking-firefox3?
Target Milestone: --- → Firefox 3
Attachment #314241 - Flags: review?(gavin.sharp) → review+
I don't think this blocks (as in, I'd back it out if it caused regressions) but tests and reviews result in a=beltzner
Flags: blocking-firefox3? → blocking-firefox3-
Attachment #314241 - Flags: approval1.9? → approval1.9+
Checking in toolkit/components/passwordmgr/src/nsLoginManager.js; new revision: 1.28; previous revision: 1.27 Checking in toolkit/components/passwordmgr/src/storage-Legacy.js; new revision: 1.26; previous revision: 1.25 Checking in toolkit/components/passwordmgr/test/Makefile.in; new revision: 1.15; previous revision: 1.14 Checking in toolkit/components/passwordmgr/test/test_bug_360493_1.html; new revision: 1.6; previous revision: 1.5 Checking in toolkit/components/passwordmgr/test/test_bug_427033.html; initial revision: 1.1 Checking in toolkit/components/passwordmgr/test/unit/test_storage_legacy_1.js; new revision: 1.10; previous revision: 1.9 Checking in toolkit/components/passwordmgr/test/unit/data/signons-427033-1.txt; initial revision: 1.1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Jasper: Could you download tomorrow's nightly build and see if this works for you now? If so mark this bug as verified and add a comment saying which build id you used to verify.
Okay, that's fine... Will this be an update for FF2 or FF3? And where can I find it when it's online?
It should be fixed in tonight's nightly FF3 build, and will be included in the final FF3 release.
Jasper: you can use a build from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/ to test.
Hmm, I downloaded the Nightly Build and tried it, and kinda works, but not really: It does save my password and username, it's in the list of saved passwords, but when I visit the site later, after removing my cookies, it still doesn't "fill in" my username and password, so I have to type them again...
You need to log in before you can comment on or make changes to this bug.