427168 - Bookmark description added to right-click Properties dialog window not copied to Description field in Properties viewer box.

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Greg Knowles]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5

In the Bookmarks Library window, there is a Properties Viewer at the bottom of window that, if opened fully, displays the various properties of a bookmark.  These include; Name, Location, Tags, Keyword, and Description.

If you right-click on a bookmark, and select Properties, you are presented with a small dialog window that drops down.  This dialog has the following four fields: Name, Location, Keyword, and Description.

If you right-click a bookmark and enter data into the four fields, then click "Save changes," the information from the four fields is duplicated in the similarly named fields in the Property Viewer, except for the Description field, where nothing appears.  If you click on a different bookmark, then come back to the bookmark you just modified, the Description field now shows the information that had been saved from the drop-down dialog window.

Also, if you modify information in the fields in the Bookmark Properties Viewer, at the bottom of the Bookmarks Library window, it is changed in the drop-down properties window that appears when you right-click the bookmark - except for any modifications you have made to the Description field in the Viewer.  Those changes are discarded.  However, if you make a modification in, let's say, the Keyword field in the Viewer, you immediately see the change in the drop-down properties window, and the changes are saved, even if you do not hit the "Save Changes" button in the drop-down window.  However, none of the functionality works with the Description field.

Reproducible: Always

Steps to Reproduce:
1.Select Bookmarks/Organize Bookmarks from Firefox Toolbar.
2.Right-click on any bookmark and select Properties.
3.Modify the Description field and click "Save changes."
4.Go to the Properties Viewer at the bottom of the Bookmarks Library window and click the "more" button, so that the Description field is displayed.
Actual Results:  
The data entered into the Description field in the drop-down window that opened when you right-clicked the bookmark is not displayed in the Description field in the Bookmark Properties Viewer.  If you click on a different bookmark and come back to this bookmark, the information is now displayed.

Expected Results:  
When information is entered into the properties fields in the drop-down Properties dialog window that appears when you right-click a bookmark, it should be duplicated in the Bookmarks Properties Viewer at the bottom of the Bookmarks Library window as soon as you click "Save Changes" in the drop-down window.

When the process is reversed, and data is entered into the fields in the Bookmarks Library Properties Viewer, at the bottom of the Bookmarks Library window, it should be saved and viewable when right-clicking that bookmark and selecting Properties from the right-click menu that appears.  But the information entered into the Description field is not saved.

Comment 1

[Thomas K. (:tom)]

Followed your steps to reproduce to the letter, changed everything including description.

Originally did it with 'more' already shown, and it changed desc.  Then I did it with less shown, then clicked more after hitting 'save changed', and it still changed desc.

So, WFM.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre ID:2008040504

1Password 2.5.12
Adblock Plus 0.7.5.3 [DISABLED]
Adblock Plus: Element Hiding Helper 1.0.2 [DISABLED]
Crash Me Now! 0.1
Firebug 1.1.0b12
Greasemonkey 0.7.20080121.0
Nightly Tester Tools 1.3

Comment 2

[Greg Knowles]

Tom, after reading you comments, I went back to check my system, and I still get the same failure.

I open Firefox 3, click on Bookmarks/Organize Bookmarks.  I open a random bookmark folder in the left-hand navigation pane and the bookmarks from that folder appear in the main window.  I select a bookmark at random and right-click on it.  I select Properties from the drop-down list.  I enter random text in the Description field and click Save Changes.  I then look at the Description field in the Properties Viewer at the bottom of the Bookmarks Library window and the field is empty.  I try clicking "Less" and "More" in the Properties Viewer, as well as clicking the arrow next to the Tags field - which opens and closes a large field below the Tags field.  The text I had entered in the Description field in the right-click Properties window never appears in the Description field of the Properties Viewer.

So, I am at a loss as to why you are not getting the same thing.  I notice in the descriptions above of our system configurations, they are different. For example, yours says"rv:1.9pre," while mine is "rv:1.9b5."  Do you think that might have anything to do with it?  BTW, what does "WFM" mean?

Comment 3

[Thomas K. (:tom)]

WFM = Works for me.

Pay attention to a different number (because I could have a pre older than your b5):

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
> rv:1.9b5) Gecko/2008032619 Firefox/3.0b5

The date is there: 2008032619 (2008 march 26 hour 19)

(In reply to comment #1)
> Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre)
> Gecko/2008040504 Minefield/3.0pre ID:2008040504

2008040504 (2008 april 5 hour 4)

You can grab a copy of the latest trunk here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

And yes, I do the exact same method as you and experience the description field updating without any attempt to 'refresh' it in the bookmarks area.  It changes as soon as I hit save changes in the bookmark properties window.

Comment 4

[Greg Knowles]

(In reply to comment #3)
I did as you suggested and downloaded & installed the latest trunk.

Once I had it up and running, I repeated the procedure I outlined above and everything worked correctly.  The Description field updated correctly.  So, the problem has, obviously, been corrected between the version I had and this latest version.

Thanks for the help.

Should I now change the status to "Fixed," or is some other status more appropriate?

Comment 5

[Thomas K. (:tom)]

(In reply to comment #4)
> So, the
> problem has, obviously, been corrected between the version I had and this
> latest version.

WFM then, thanks.

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv