Closed
Bug 427291
Opened 18 years ago
Closed 18 years ago
Multiple focus events fired when clicking XUL textbox
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
906 bytes,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
Caused by the patch for bug 403471. Normal clicks focus the anonymous html:input (textbox.inputField), but then the click handler is called, which focuses the <textbox>, which then redirects focus to the html:input again. We can avoid this by just focusing the input field directly from the click handler.
|
Assignee | |
Comment 1•18 years ago
|
||
I noticed this because I was seeing redundant calls to nsAutocompleteController::SetInput, which is called from the autocomplete textbox's focus handler.
Keywords: regression
|
|
Assignee | |
Comment 2•18 years ago
|
||
|
|
Assignee | |
Comment 3•18 years ago
|
||
I don't think this needs to land for Firefox 3.
Target Milestone: --- → mozilla2.0
Version: unspecified → Trunk
|
||
Comment 4•18 years ago
|
||
Comment on attachment 313846 [details] [diff] [review]
patch
r=mano
Attachment #313846 -
Flags: review?(mano) → review+
|
|
Assignee | |
Updated•18 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•18 years ago
|
||
Pushed in changeset 35d59b3bbc81.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla2.0 → mozilla1.9.1
|
|
Assignee | |
Updated•18 years ago
|
Target Milestone: mozilla1.9.1 → mozilla1.9.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•