427353 - Can't show recommended add-ons and use search functions in Korean addon manager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Channy Yun [:channy]]

Attachment: don't show recommended addons.

In the latest Firefox 3 Korean version, Addon manager don't show recommended addons and the result of search as like attached screenshots.

I tested Japanese version, but it works. There is no differences values of extensions.getAddons.search.url and extensions.getAddons.recommended.url in about:config.

Comment 1

[Channy Yun [:channy]]

Attachment: don't show the search result

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Is this the same bug as bug 427304? I'm not sure, because that screenshot seems to be of you searching for an ASCII string, which should work OK.

Comment 3

[Channy Yun [:channy]]

(In reply to comment #2)
> Is this the same bug as bug 427304? I'm not sure, because that screenshot seems
> to be of you searching for an ASCII string, which should work OK.
> 

In my investigation, profileSelection.xul contained 'style="width: 30em;"' without assigning height value. To fix it, style value must be localized in profileSelection.dtd. as like createProfije.xul and createProfile.dtd.

Comment 4

[Channy Yun [:channy]]

Please ignore comment #3. I confused bug number. 

Comment 5

[Channy Yun [:channy]]

(In reply to comment #2)
> Is this the same bug as bug 427304? I'm not sure, because that screenshot seems
> to be of you searching for an ASCII string, which should work OK.
> 

It seems to be another issue. In Korean version, recommended addons is not shown. In case of searching of ASCII keyword, the number of search is shown. It means Firefox get data by search from addon server. But, its result is not shown in dialog box.

Comment 6

[Axel Hecht [:Pike]]

I can reproduce this with the language pack on http://l10n.mozilla.org/~buildslave/trunk/, but I have no clue what happened.

I suspected something like bug 424081, but the URL itself seems to be fine.

I see a problem in the reporterOverlay, which I blame on the Korean localization, but I doubt that has something to do with this bug.

Comment 7

[Dave Townsend [:mossop]]

This is an issue with how we check whether an extension in the results is compatible with the current application. We currently use the application name to compare and unfortunately AMO is returning a localised version of the name which does not match the unlocalised name in nsIXULAppInfo.

Laura, we talked about this before but apparently it never happened, can we get the application guid ({ec8030f7-c20a-464f-9b0e-13a3a9e97384} for Firefox f.e.) included in the application block?

Comment 8

[Dave Townsend [:mossop]]

Attachment: EM patch rev 1

From IRC, Laura will add the application <guid> element as part of the <application> block that should hopefully go live tomorrow evening. This patch switches to use it for matching.

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 314098 [details] [diff] [review]
EM patch rev 1

Forgot the tests...

Comment 10

[Dave Townsend [:mossop]]

Attachment: EM patch rev 2

We've decided to use appID as the guid element and the schema version is updating to 1.1. This patch is fairly trivial, just also need to update the tests to match the new schema.

Comment 11

[Laura Thomson :laura]

API changes in r12071.

Comment 12

[Dave Townsend [:mossop]]

Comment on attachment 314397 [details] [diff] [review]
EM patch rev 2

Seeking approval to land this fix for the get add-ons pane in localised versions.

This is a very small low-impact patch that can only affect the get add-ons pane. The unit tests are there verifying that the change is doing what it is supposed to do and I have verified that AMO has been updated to match what the patch expects.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314397 [details] [diff] [review]
EM patch rev 2

a1.9=beltzner

Comment 14

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/src/nsAddonRepository.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsAddonRepository.js,v  <--  nsAddonRepository.js
new revision: 1.5; previous revision: 1.4
done
Checking in toolkit/mozapps/extensions/test/unit/data/test_bug404024.xml;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug404024.xml,v  <--  test_bug404024.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/mozapps/extensions/test/unit/data/test_bug417606.xml;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug417606.xml,v  <--  test_bug417606.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml,v  <--  test_bug424262.xml
new revision: 1.2; previous revision: 1.1
done

Comment 15

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; ko; rv:1.9pre) Gecko/2008050806 Minefield/3.0pre

Comment 16

[Channy Yun [:channy]]

Attachment: Add-on manager search in Korean

I found a problem to search addons with translated text into Korean.
In case of Foxmarks bookmark syncronizer (https://addons.mozilla.org/ko/firefox/addon/2410), it didn't show proper search result in addon manager of Firefox 3 RC1 ko version.

Comment 17

[Axel Hecht [:Pike]]

Well, foxmarks is only compatible with fx2, not 3, so this seems to be the right behaviour. I get the incompatible message in my en-US build, too.