427375 - If a review is sent without rating, it will be counted as 0/5

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Nicolas Turcot (:nico@nc)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre
Build Identifier: 3.2

The first review details are:
 Not yet rated  by ban249 on March 28, 2008 (rated 0)

The users seems not to have selected a number of stars, and it has been counted as a 0/5 vote, instead of having no impact on the rating.

Reproducible: Always

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirming so we can take a look at this.

Isn't "0" a valid rating?  Perhaps not, if the "1" rating means "Hate it".

Comment 2

[Nicolas Turcot (:nico@nc)]

I think if somebody send a review without choosing a number of stars, he was not looking to give 0/5 to the extension.

Moreover, if you choose a rating, you can not change to 0/5 then. So it should not be a valid rating, and reviews with no star selected should not modify the extension rating.

Comment 3

[Ryan Doherty (:rdoherty)]

(In reply to comment #2)
> Moreover, if you choose a rating, you can not change to 0/5 then. So it should
> not be a valid rating, and reviews with no star selected should not modify the
> extension rating.

Agreed, I'll look into setting the rating to null/'' and see how that works. 

Comment 4

[Fred Wenzel [:wenzel]]

<OT>iTunes treats "not yet rated" as 0 stars too, and I hate it!</OT>

Comment 5

[Ryan Doherty (:rdoherty)]

Previous functionality required a rating, so I'm forcing a rating for this one too. 

Comment 6

[Ryan Doherty (:rdoherty)]

Attachment: Patch

Small change and new string. Requesting review from Will for localization feedback.

Comment 7

[Ryan Doherty (:rdoherty)]

Fixed in r12131

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks for fixing this, Ryan--and all, sorry for missing it.

Verified FIXED using https://remora-reskin.stage.mozilla.com/en-US/firefox/reviews/add/6543.

http://img390.imageshack.us/my.php?image=picture6wv7.png

Comment 9

[Jesse Andrews]

I just got a new review on my addon without a rating, and the rating went down.

https://addons.mozilla.org/en-US/firefox/addon/5756