427532 - [Mac] Unexpected "+(plus)" mark on Today's button (only when small icon)

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Shinya Kuribayashi]

Attachment: "+(plus)" mark on Today's button

User-Agent: Thunderbird 2.0.0.12
Build Identifier: Lightning 0.8rc2 2008033121

In calendar-mode, I've noticed that Today's icon has an wrong "+(plus)" mark.
This is only observed when Small Icon selected. Is this expected?

Steps to Reproduce:
1. Switch to Calendar-mode
2. Right click on toolbar => Customize... => Use Small Icons
3. See Today's button.

Reproducible: Always

Note:
- I've checked with fresh profile on Mac.
- Linux Tb+Lightning0.8rc2 doesn't have this issue.

Comment 1

[Shinya Kuribayashi]

Attachment: Normal size icon

Comment 2

[Stefan Sitter [:ssitter]]

The + sign is shown as specified in the image:
http://mxr.mozilla.org/mozilla1.8/source/calendar/base/themes/pinstripe/toolbar-large.png
http://mxr.mozilla.org/mozilla1.8/source/calendar/base/themes/pinstripe/toolbar-small.png

But it makes more sense if it would be on the New Task image as done in the winstripe theme.

Comment 3

[Stefan Sitter [:ssitter]]

Christian, if I recall correctly you created the new images? Could you provide an updated set if the current look is not as intended?

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This issue still exists in the latest nightlys, Im not yet sure we actually still use the icon though.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I've corrected the icon locally and will push this soon. I don't think we need a review for this, so r=me :)

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/811a4bc1f65f>
-> FIXED

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/954837554355>
a=philipp