427690 - bootstrap Sign step should use HTTP not look for local file

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Robert Helmer [:rhelmer]]

Now that bug 415970 has landed, the only thing that uses the FTP setup on the master is the Sign step (which looks for a logfile and exits when it finds it).

This could instead use HTTP to check for the existence of the file on the $stagingServer.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: [checked in] check for signing log via HTTP not local file

This seems to do the trick, what do you think Nick?

Would need a small master.cfg change to take this (change the slave used for Sign step).

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 314256 [details] [diff] [review]
[checked in] check for signing log via HTTP not local file

Looks good, r+. I had a look on the 1.8 prod slaves, and only the linux one has LWP::Simple installed.

Comment 3

[Robert Helmer [:rhelmer]]

Looks like the Linux slaves already do this on the staging side, going to land this.

Comment 4

[Robert Helmer [:rhelmer]]

Comment on attachment 314256 [details] [diff] [review]
[checked in] check for signing log via HTTP not local file

Checking in Bootstrap/Step/Sign.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Sign.pm,v  <--  Sign.pm
new revision: 1.12; previous revision: 1.11
done

Comment 5

[Robert Helmer [:rhelmer]]

Le sigh.. the 1.9 Centos ref platform apparently does not have perl-libwww installed. 

Comment 6

[Robert Helmer [:rhelmer]]

Attachment: [checked in] quick wget workaround

Could do something like this, or install the needed RPM on the machines + ref platform. What do you think Nick?

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 314441 [details] [diff] [review]
[checked in] quick wget workaround

Not quite so elegant but WFM, r+

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Also caused bustage on the staging setups in the make test part of <os>_prestage.

Comment 9

[Robert Helmer [:rhelmer]]

Comment on attachment 314441 [details] [diff] [review]
[checked in] quick wget workaround

Checking in Bootstrap/Step/Sign.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Sign.pm,v  <--  Sign.pm
new revision: 1.13; previous revision: 1.12
done