427758 - Crash [@ nsGlobalWindow::IsInModalState()] when canceling a print dialog that was appearing from a timer

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P2)

Description

[Martijn Wargers (dead)]

Attachment: testcase

This is currently nr. 66 on the top crasher list.
There are comments from people that crash when they dismiss the print dialog from Google Maps. I was able to reproduce it that way too.

But I can reproduce it with the testcase too, although I need to retry it a lot of times (I use ctrl-r and click on the cancel dialog quickly a lot of times).

This seems to have regressed between 2008-03-30 and 2008-04-02:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-03-30+04&maxdate=2008-04-02+09&cvsroot=%2Fcvsroot
I think a regression from bug 424377, somehow.


http://crash-stats.mozilla.com/report/index/914f7dde-0550-11dd-9564-001321b13766
0  	xul.dll  	nsGlobalWindow::IsInModalState  	 mozilla/dom/src/base/nsGlobalWindow.cpp:5598
1 	xul.dll 	nsGlobalWindow::RunTimeout 	mozilla/dom/src/base/nsGlobalWindow.cpp:7586
2 	xul.dll 	nsGlobalWindow::TimerCallback 	mozilla/dom/src/base/nsGlobalWindow.cpp:8085
3 	xul.dll 	nsTimerImpl::Fire 	mozilla/xpcom/threads/nsTimerImpl.cpp:400
4 	xul.dll 	nsTimerEvent::Run 	mozilla/xpcom/threads/nsTimerImpl.cpp:490
5 	xul.dll 	nsThread::ProcessNextEvent 	mozilla/xpcom/threads/nsThread.cpp:510
6 	xul.dll 	nsBaseAppShell::Run 	mozilla/widget/src/xpwidgets/nsBaseAppShell.cpp:170
7 	nspr4.dll 	PR_GetEnv 	
8 	firefox.exe 	wmain 	mozilla/toolkit/xre/nsWindowsWMain.cpp:87
9 	firefox.exe 	firefox.exe@0x217f 	
10 	kernel32.dll 	BaseProcessStart

Comment 1

[Daniel Holbert [:dholbert]]

I can reproduce this using Martijn's testcase on the first try.

Running Windows Vista, with latest-trunk:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040805 Minefield/3.0pre)

Comment 2

[Damon Sicore (:damons)]

Thanks, Daniel.  

Yeah, this can be reproduced 100% of the time.   Google maps is likely the
number one place that people will print.  Gotta block.

Comment 3

[Daniel Holbert [:dholbert]]

Moving to Printing component.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Added a comment to bug 424377.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Backed out bug 424377.

Comment 6

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008050606 Minefield/3.0pre ID:2008050606 - no crash on testcase