427791 - [si] dialog.style in customizeToolbar.dtd should not be translated

Status: RESOLVED FIXED

(Mozilla Localizations :: si / Sinhala, defect)

Description

[Marek Stępień [:marcoos, inactive]]

In your locale, this entity in customizeToolbar.properties:

<!ENTITY dialog.style "width: 635px; height: 400px;">

is translated into your local language. This is not what you
should do here. This is CSS style code telling how wide and high
that window should be - so you should only change the numbers
'635' and '400', but do not translate the words 'width' nor 'height'.

For example, this is OK (if you want the window to have the dimensions 735x420:

<!ENTITY dialog.style "width: 735px; height: 420px;">

and this is WRONG:

<!ENTITY dialog.style "[your local word for 'width']: 635px; [your local word for 'height']: 400px;">

Comment 1

[Marek Stępień [:marcoos, inactive]]

Note that by "customizeToolbar.properties" I actually meant the file "toolkit/chrome/global/customizeToolbar.dtd", not the .properties one.

My bad, sorry for the confusion.

Comment 2

[Danishka]

Hi Marek,

I did same mistake in few places. :(
At the moment(this PC) not having the Fx l10n content. So, will update them ASAP.

Comment 3

[Danishka]

Hi Marek,

Reversed the translated strings back and commited.
Please check now. :)

Comment 4

[Marek Stępień [:marcoos, inactive]]

This looks OK now, marking as fixed (should have done it a year ago :))