Created attachment 314384 [details] [diff] [review] The fix Alive tests start up the application and check its still alive after 45 seconds - turning the tinderbox orange if the app dies or doesn't start for some reason. We should have this on the Windows Thunderbird trunk to provide some more coverage at a basic level.
Oh, this will also enable the regxpcom test, but that is just registering chrome and shouldn't cause any problems either.
Um, isn't it running already? Just before the packaging step, the log says Running MozillaAliveTest test ... Timeout = 45 seconds. Begin: Tue Apr 8 12:08:22 2008 cmd = /e/builds/tinderbox/Tb-Trunk/WINNT_5.2_Depend/mozilla/obj-tb-trunk/dist/bin/thunderbird.exe -P default Process killed. Took 2 seconds to die. End: Tue Apr 8 12:09:08 2008 ----------- Output from MozillaAliveTest ------------- ----------- End Output from MozillaAliveTest --------- MozillaAliveTest: thunderbird.exe successfully stayed up for 45 seconds. which I always assumed meant it was running (particularly since I've seen things turn it orange, without any other test that could be failing). Not sure why it runs, unless the default is actually to run it unless it's uncommented and set to 0.
(In reply to comment #2) > Um, isn't it running already? Just before the packaging step, the log says Bah, tinderbox setup code sucks. Assuming this doesn't affect anything, can we just leave it in for my sanity?
Running it explicitly instead of implicitly seems as reasonable as anything in the insane world of Tinderbox :)
So what's causing the implicit run to happen? And would checking in this patch cause a second run?
(In reply to comment #6) > So what's causing the implicit run to happen? And would checking in this patch > cause a second run? > http://mxr.mozilla.org/seamonkey/source/tools/tinderbox/tinder-defaults.pl#60 loaded in here: http://mxr.mozilla.org/seamonkey/source/tools/tinderbox/build-seamonkey-util.pl#65 (in the InitVars function before the LoadConfig function).
Oh and keeping it would also make it consistent with the Thunderbird linux & mac tinderbox configs.
Sold w.r.t. making it explicit. r+sr stands.
I just checked the latest build log, AliveTest still running fine. Therefore marking fixed.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Summary: Enable Alive tests on Windows Thunderbird trunk tinderbox → Explicitly Enable Alive tests on Windows Thunderbird trunk tinderbox
You need to log in before you can comment on or make changes to this bug.